Upgrade deprecated dependencies (#1124)

* upgrade lighthouse cli * upgrade formatjs cli
SalesforceCommerceCloud · Apr 24, 2023 · 2f73309 · 2f73309
1 parent 68cb474
commit 2f73309
Show file tree

Hide file tree

Showing 6 changed files with 991 additions and 5,222 deletions.
diff --git a/packages/pwa-kit-dev/package-lock.json b/packages/pwa-kit-dev/package-lock.json
diff --git a/packages/template-retail-react-app/app/components/swatch-group/index.test.js b/packages/template-retail-react-app/app/components/swatch-group/index.test.js
@@ -113,7 +113,7 @@ describe('Swatch Component', () => {
                 <Page />
             </Router>
         )
-        expect(screen.getAllByRole('link')).toHaveLength(data.values.length)
+        expect(screen.getAllByRole('radio')).toHaveLength(data.values.length)
     })
 
     test('swatch can be selected', () => {
@@ -126,8 +126,8 @@ describe('Swatch Component', () => {
             </Router>
         )
 
-        expect(screen.getAllByRole('link')).toHaveLength(data.values.length)
-        const firstSwatch = screen.getAllByRole('link')[0]
+        expect(screen.getAllByRole('radio')).toHaveLength(data.values.length)
+        const firstSwatch = screen.getAllByRole('radio')[0]
         fireEvent.click(firstSwatch)
         waitFor(() => {
             expect(history.search).toBe('?color=BLACKFB')

diff --git a/packages/template-retail-react-app/app/components/swatch-group/swatch.jsx b/packages/template-retail-react-app/app/components/swatch-group/swatch.jsx
@@ -38,6 +38,7 @@ const Swatch = (props) => {
             }}
             aria-checked={selected}
             variant="outline"
+            role="radio"
         >
             <Center {...styles.swatchButton}>
                 {children}

diff --git a/packages/template-retail-react-app/app/partials/product-view/index.test.js b/packages/template-retail-react-app/app/partials/product-view/index.test.js
@@ -210,7 +210,7 @@ test('onVariantSelected callback is called after successfully selected a variant
         />
     )
 
-    const size = screen.getByRole('link', {name: /xl/i})
+    const size = screen.getByRole('radio', {name: /xl/i})
     userEvent.click(size)
 
     await waitFor(() => {