fix(radio-button): incorrect spacing on fieldHelp with validationRedesignOptIn flag #7122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdavies73
reviewed
Dec 10, 2024
| @@ -26,9 +26,9 @@ export interface RadioButtonProps | |||
| onClick?: (ev: React.MouseEvent<HTMLInputElement>) => void; | |||
| /** the value of the Radio Button, passed on form submit */ | |||
| value: string; | |||
| /** Overrides the default tooltip position */ | |||
| /** [Legacy] Overrides the default tooltip position */ | |||
There was a problem hiding this comment.
suggestion: if you're updating these prop descriptions, it may be worth updating the remaining prop descriptions for helpAriaLabel and tooltipPosition which do not include a legacy description
| @@ -53,9 +53,9 @@ For more information check our [Validations](../?path=/docs/documentation-valida | |||
|
|
|||
| #### New designs validation | |||
|
|
|||
| The folowing examples use the new validation pattern that is available by setting the `validationRedesignOptIn` flag on the `CarbonProvider` to true. | |||
| The following examples use the new validation pattern that is available by setting the `validationRedesignOptIn` flag on the `CarbonProvider` to true. | |||
There was a problem hiding this comment.
suggestion: it may be worth updating other docs which include the same spelling mistake, a quick search from the codebase shows this same mistake present in 14 files
…signOptIn flag Fixes issue where fieldHelp did not have correct spacing with the new validaiton opt in flag. Also fixes issue where all radio buttons in a required group would display the asterisk. fix #6985
damienrobson-sage
approved these changes
Dec 11, 2024
tomdavies73
approved these changes
Dec 11, 2024
paulrobinson88
approved these changes
Dec 12, 2024
|
🎉 This PR is included in version 144.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6985
Proposed behaviour
When
validationRedesignOptInflag is true:RadioButtonGrouplegend.Current behaviour
When
validationRedesignOptInflag is true:RadioButtons within a group.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
See bugs demo
See 'With New Validation' and 'With New Validation Group' test stories.