feat(draggable-container): add flexDirection prop #7102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edleeks87
reviewed
Nov 28, 2024
| const StyledIcon = styled(Icon)` | ||
| margin-left: auto; | ||
| `; | ||
| const StyledIcon = styled(Icon)``; |
There was a problem hiding this comment.
Question: Do we need this anymore can we just render Icon?
| @@ -46,6 +46,24 @@ export const DefaultStory: Story = () => ( | |||
| ); | |||
| DefaultStory.storyName = "Default"; | |||
|
|
|||
| export const FlexDirectionStory: Story = () => ( | |||
There was a problem hiding this comment.
suggestion: it might be worth changing the children a bit here so when a user drags it's obvious the order has been updated etc
There was a problem hiding this comment.
Nothing more to add from me. Address the comments by @edleeks87 and I'll get this approved 😄
edleeks87
approved these changes
Nov 28, 2024
DipperTheDan
approved these changes
Nov 29, 2024
dariusbercea-sage
approved these changes
Dec 4, 2024
adds the flexDirection prop which provides consumers with the means to change the flex-direction css attribute from row to row-reverse or vice versa fix #7089
|
🎉 This PR is included in version 144.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7089
Proposed behaviour
adds the
flexDirectionprop which provides consumers with the means to change the flex-direction css attribute from row to row-reverse or vice versaCurrent behaviour
Currently, consumers have no control over where the "draggable" icon is placed, and it is always rendered on the right-hand side by default
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions