Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build script no longer uses cross-env and args can be passed t… #7094

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

edleeks87
Copy link
Contributor

…o build-storybook script

Proposed behaviour

Removes cross-env call in build script as environment variables are being set inside the function's scope so should work avoid cross-platform issues without the need for cross-env or dot-env etc.

Ensures build-storybook scrip can receive args.

Current behaviour

The build script still calls cross-env.
The build-storybook cannot receive any args passed when it is called.

Checklist

  • Commits follow our style guide

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Run npm run build on a windows machine to test it works cross-platform after cross-env removed

Copy link
Contributor

@damienrobson-sage damienrobson-sage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@edleeks87
Copy link
Contributor Author

edleeks87 commented Nov 26, 2024

Discussed with @Parsium on slack about whitelisting the args (plus webpack stat flag) we want to pass so I'm going to add that now

@edleeks87
Copy link
Contributor Author

Scripts have been tested by @stephenogorman on windows so I'm removing the QA flag

@edleeks87 edleeks87 merged commit 79cbb7b into master Nov 26, 2024
24 checks passed
@edleeks87 edleeks87 deleted the fix-build-script branch November 26, 2024 12:29
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 144.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants