-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(date-input, date-range): upgrade react-day-picker to v9 #7080
base: master
Are you sure you want to change the base?
Conversation
e9f5f82
to
0f04a6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work getting this update done so fast @damienrobson-sage, I think it's worth rebasing with master
as there's a few conflicts etc
src/components/date/__internal__/date-picker/day-picker.style.ts
Outdated
Show resolved
Hide resolved
src/components/date/__internal__/date-picker/day-picker.style.ts
Outdated
Show resolved
Hide resolved
src/components/date/__internal__/date-picker/date-picker.component.tsx
Outdated
Show resolved
Hide resolved
f697887
to
d4e9a17
Compare
24eb141
to
b25334a
Compare
src/components/date/__internal__/date-picker/date-picker.component.tsx
Outdated
Show resolved
Hide resolved
src/components/date/__internal__/date-picker/date-picker.component.tsx
Outdated
Show resolved
Hide resolved
7ae8e5d
to
b067a4d
Compare
src/components/date/__internal__/date-picker/date-picker.component.tsx
Outdated
Show resolved
Hide resolved
src/components/date/__internal__/date-picker/date-picker.component.tsx
Outdated
Show resolved
Hide resolved
src/components/date/__internal__/date-picker/date-picker.component.tsx
Outdated
Show resolved
Hide resolved
a680579
to
9e43132
Compare
209d0d9
209d0d9
to
0fe4861
Compare
0fe4861
to
beb4f4f
Compare
Upgrades react-day-picker to remove the dependency on React 18
beb4f4f
to
bd75a0f
Compare
while there is some color/spacing adjustments, looks fine to me and I know there are designs are date input grades in the future anyway, so this is good. |
Upgrades react-day-picker to remove the dependency on React 18
Proposed behaviour
Current behaviour
Checklist
d.ts
file added or updated if requiredQA
Additional context
Testing instructions