Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(date-input, date-range): upgrade react-day-picker to v9 #7080

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

damienrobson-sage
Copy link
Contributor

Upgrades react-day-picker to remove the dependency on React 18

Proposed behaviour

Current behaviour

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Copy link
Contributor

@edleeks87 edleeks87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work getting this update done so fast @damienrobson-sage, I think it's worth rebasing with master as there's a few conflicts etc

jest.config.ts Outdated Show resolved Hide resolved
src/components/date/date.component.tsx Outdated Show resolved Hide resolved
src/components/date/date.component.tsx Outdated Show resolved Hide resolved
src/components/date/date.stories.tsx Show resolved Hide resolved
@damienrobson-sage damienrobson-sage force-pushed the FE-6648-upgrade-react-day-picker branch 3 times, most recently from f697887 to d4e9a17 Compare November 20, 2024 08:27
@damienrobson-sage
Copy link
Contributor Author

Playwright tests pass locally but seem a little flaky when running in the pipeline.
Screenshot 2024-11-20 at 08 25 18

@damienrobson-sage damienrobson-sage force-pushed the FE-6648-upgrade-react-day-picker branch 2 times, most recently from 24eb141 to b25334a Compare November 20, 2024 11:22
@damienrobson-sage damienrobson-sage force-pushed the FE-6648-upgrade-react-day-picker branch 3 times, most recently from 7ae8e5d to b067a4d Compare November 25, 2024 17:28
edleeks87
edleeks87 previously approved these changes Nov 26, 2024
Parsium
Parsium previously approved these changes Nov 27, 2024
edleeks87
edleeks87 previously approved these changes Nov 27, 2024
@edleeks87 edleeks87 marked this pull request as ready for review November 27, 2024 13:50
@edleeks87 edleeks87 requested review from a team as code owners November 27, 2024 13:50
@damienrobson-sage damienrobson-sage force-pushed the FE-6648-upgrade-react-day-picker branch 2 times, most recently from 209d0d9 to 0fe4861 Compare December 2, 2024 08:40
Parsium
Parsium previously approved these changes Dec 2, 2024
Upgrades react-day-picker to remove the dependency on React 18
@harpalsingh
Copy link
Member

while there is some color/spacing adjustments, looks fine to me and I know there are designs are date input grades in the future anyway, so this is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants