Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog is re-added to the DOM after opening Vertical Menu #7073

Open
1 task done
rawlmp opened this issue Nov 13, 2024 · 1 comment · May be fixed by #7093
Open
1 task done

Dialog is re-added to the DOM after opening Vertical Menu #7073

rawlmp opened this issue Nov 13, 2024 · 1 comment · May be fixed by #7093
Labels
Bug On Backlog Squad SBC Gaudi

Comments

@rawlmp
Copy link

rawlmp commented Nov 13, 2024

Description

At some point we need to show a modal to prevent navigation before saving changes but the modal shown is colliding with Vertical Menu in mobile devices after clicking a Navigation Item.

It seems the Dialog component is re-added to the DOM after opening Vertical Menu, staying in top and blocking any user action.

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-kbwisw?file=src%2FApp.tsx

Steps to reproduce

Info is provided in the Stackblitz example

JIRA ticket numbers (Sage only)

SBS-114293

Suggested solution

No response

Carbon version

141.0.8

Design tokens version

4.34.0

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@rawlmp rawlmp added Bug triage Triage Required labels Nov 13, 2024
@Parsium
Copy link
Contributor

Parsium commented Nov 19, 2024

FE-6908

@Parsium Parsium added On Backlog and removed triage Triage Required labels Nov 19, 2024
mihai-albu-sage added a commit that referenced this issue Nov 26, 2024
@mihai-albu-sage
fix(vertical-menu-full-screen): register Fullscreen subcomponent as a…
48fc0ab 
… Carbon modal

componnet is now using useModalManager to register as a modal

fixes: #7073
mihai-albu-sage added a commit that referenced this issue Nov 26, 2024
@mihai-albu-sage
fix(vertical-menu-full-screen): register Fullscreen subcomponent as a…
efc46d9 
… Carbon modal

componnet is now using useModalManager to register as a modal

fixes: #7073
@mihai-albu-sage mihai-albu-sage linked a pull request Nov 26, 2024 that will close this issue
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog Squad SBC Gaudi
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(vertical-menu-full-screen): register Fullscreen subcomponent as a Carbon modal Sage/carbon
3 participants
@rawlmp @Parsium @damienrobson-sage