Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDS-2213 add to synapse api tests #613

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

lakikowolfe
Copy link
Contributor

Added to Synapse API tests to improve testing coverage.

Made a couple changes to synapse_rest_api.R to make some minor improvements.

@lakikowolfe lakikowolfe changed the base branch from main to develop August 21, 2024 20:44
@afwillia afwillia self-requested a review August 21, 2024 21:30
Copy link
Contributor

@afwillia afwillia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, reminder to change expect_false to expect_true in the certification test.

@afwillia afwillia merged commit b8d5822 into develop Aug 22, 2024
1 of 2 checks passed
@afwillia afwillia deleted the fds-2213-synapse-api-tests branch August 22, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants