Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-791] Implement Great Expectations for the overall_scores Dataset #115

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Jan 31, 2024

Description:

This PR implements a GX expectation suite for the overall_scores dataset.

Please let me know if there are any additional expectations I should add, or if there are any adjustments to be made to the expectations I have already implemented.

Notes:

  • Values I have chosen for expectations like expect_column_values_to_be_between and expect_column_value_lengths_to_be_between are based on looking at the example dataset on Synapse.
  • This change has been tested with adt test_config.yaml. Example results can be downloaded from here.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@jaclynbeck-sage jaclynbeck-sage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The min/max values for the different scores seem correct based on what is currently in Agora.

Copy link
Contributor

@JessterB JessterB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Brad!

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 excellent!

@BWMac BWMac merged commit d1e2a72 into dev Feb 1, 2024
9 checks passed
@BWMac BWMac deleted the bwmac/IBCDPE-791/gx_overall_scores branch February 1, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants