Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1170] Add missing profile to data guide #14

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

rxu17
Copy link
Contributor

@rxu17 rxu17 commented Feb 21, 2024

Purpose: Adds the missing center profile for our GOLD center. The docker image tagged at sagebionetworks/genie-data-guide:latest on dockerhub needs to be rebuilt in order for this to work on Nextflow Workflow Tower.

I don't have the permissions to push to sagebionetworks on dockerhub, but tested consortium_release on nf-genie on the rebuilt image locally and it works (data guide on test pipeline gets outputted): https://www.synapse.org/#!Synapse:syn21895009

Once this gets pushed to main, the docker image will rebuild on dockerhub, and the nextflow workflow tower run will work

@rxu17 rxu17 requested a review from a team February 21, 2024 19:58
@rxu17
Copy link
Contributor Author

rxu17 commented Feb 21, 2024

@thomasyu888 Could you add me as admin or add @Sage-Bionetworks/genie-reviewers to have write access to the repo?

@rxu17 rxu17 requested review from thomasyu888 and removed request for a team February 21, 2024 20:03
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! Just a comment, but going to pre-approve. Ill leave it to you to decide whether you want to push this when processing is still happening

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rxu17
Copy link
Contributor Author

rxu17 commented Feb 21, 2024

🔥 LGTM! Just a comment, but going to pre-approve. Ill leave it to you to decide whether you want to push this when processing is still happening

Good point, I'll wait for now.

@rxu17 rxu17 merged commit 09485ab into main Feb 22, 2024
2 checks passed
@rxu17 rxu17 deleted the gen-1170-add-missing-profile branch February 22, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants