-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-1033/DPE-1188] Add docker authenticated pulls & Drop SigNoz self hosted #54
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM!
Thanks for doing this - we do have a sage organization which we could potentially add this individual. Once added, this individual could have less restrictions with Docker pulls, but maybe we can figure that out later.
I'd like someone else on @Sage-Bionetworks-Workflows/dpe to do a final review.
Another critical note: be sure that Signoz cloud can be used before we drop this and then have to resurrect all of this. Alberto did approve months ago but nothing is final until we get that subscription.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one question
@@ -2354,7 +2354,7 @@ redis: | |||
# Auth secret for a private registry | |||
# This is used if pulling airflow images from a private registry | |||
registry: | |||
secretName: ~ | |||
secretName: docker-cfg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would it work if we ever were to pull an image from another registry such as quay.io/would we ever need to do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we were to use another registry we would update the resource "kubernetes_secret" "docker-cfg"
to include the authentication for the other registry. Or, as this S/O covers - The alternative is to create separate secrets for each registry we might want to use: https://stackoverflow.com/a/59717512
Further docs: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/#using-images-from-multiple-registries
Using images from multiple registries
A pod can have multiple containers, each container image can be from a different registry. You can use multiple imagePullSecrets with one pod, and each can contain multiple credentials.
The image pull will be attempted using each credential that matches the registry. If no credentials match the registry, the image pull will be attempted without authorization or using custom runtime specific configuration.
Problem:
Solution:
Testing: