Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hyperparameter optimization for RNNs and CNNs #923

Merged
merged 27 commits into from
Aug 28, 2024

Conversation

sibre28
Copy link
Contributor

@sibre28 sibre28 commented Aug 16, 2024

Closes #912

Summary of Changes

New Features:

  • fit_by_exhaustive_search now also works for RNNs and CNNs
  • ClassificationMetrics and RegressionMetrics now also work for TimeSeriesDatasets, even when the predictions are of type list.
  • Raise Error when classifing time series data with continuous = True, as we dont currently support this use-case (since both classification and continuous predictions require the amount of neurons in the last layer to be set differently, according to either the number of classes or the number of values to predict; The output would have to be 2-dimensional)

@sibre28 sibre28 linked an issue Aug 16, 2024 that may be closed by this pull request
@sibre28 sibre28 marked this pull request as draft August 16, 2024 00:47
Copy link
Contributor

github-actions bot commented Aug 16, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 5 0 0 1.67s
✅ PYTHON mypy 5 0 3.62s
✅ PYTHON ruff 5 0 0 0.36s
✅ REPOSITORY git_diff yes no 0.35s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 99.26740% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.17%. Comparing base (ccb60c3) to head (76b78ca).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
src/safeds/ml/nn/_model.py 99.11% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
+ Coverage   98.14%   98.17%   +0.03%     
==========================================
  Files         122      122              
  Lines        6958     7183     +225     
==========================================
+ Hits         6829     7052     +223     
- Misses        129      131       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sibre28 sibre28 marked this pull request as ready for review August 20, 2024 01:09
@sibre28 sibre28 merged commit b1e8933 into main Aug 28, 2024
10 checks passed
@sibre28 sibre28 deleted the 912-hyperparamteroptimization-for-rnns-and-cnns branch August 28, 2024 17:18
@lars-reimann lars-reimann changed the title feat: hyperparamteroptimization for rnns and cnns feat: hyperparameter optimization for RNNs and CNNs Sep 17, 2024
lars-reimann pushed a commit that referenced this pull request Sep 17, 2024
## [0.28.0](v0.27.0...v0.28.0) (2024-09-17)

### Features

* hyperparameter optimization for classical models ([#843](#843)) ([d8f7491](d8f7491)), closes [#264](#264)
* hyperparamteroptimization for rnns and cnns ([#923](#923)) ([b1e8933](b1e8933)), closes [#912](#912)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperparamteroptimization for RNNs and CNNs
4 participants