perf: lazily import our modules and external libraries #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 62 62
Lines 4634 4748 +114
==========================================
+ Hits 4634 4748 +114 ☔ View full report in Codecov by Sentry. |
# Conflicts: # src/safeds/data/tabular/containers/_tagged_table.py # src/safeds/exceptions/__init__.py # src/safeds/ml/nn/__init__.py # src/safeds/ml/nn/_model.py
lars-reimann
force-pushed
the
lazy-imports-in-init-files
branch
from
924df2c to
99879f6
Compare
lars-reimann
force-pushed
the
lazy-imports-in-init-files
branch
from
99879f6 to
509bc02
Compare
|
@Safe-DS/library For future additions, please move all imports of external libraries into the functions that need them, so they get evaluated lazily. It's hideous, but startup is much faster, as explained in the opening post. |
lars-reimann
pushed a commit
that referenced
this pull request
Apr 17, 2024
## [0.21.0](v0.20.0...v0.21.0) (2024-04-17) ### Features * add ARIMA model ([#577](#577)) ([8b9c7a9](8b9c7a9)), closes [#570](#570) * Add ImageList class ([#534](#534)) ([3cb74a2](3cb74a2)), closes [#528](#528) [#599](#599) [#600](#600) * more hash, sizeof and eq implementations ([#609](#609)) ([2bc0b0a](2bc0b0a)) ### Performance Improvements * Add special case to `Table.add_rows` to increase performance ([#608](#608)) ([ffb8304](ffb8304)), closes [#606](#606) * improve performance of model & forward layer ([#616](#616)) ([e856cd5](e856cd5)), closes [#610](#610) * lazily import our modules and external libraries ([#624](#624)) ([20fc313](20fc313)) * treat Tables specially when calling add_rows ([#606](#606)) ([e555b85](e555b85)), closes [#575](#575)
|
🎉 This PR is included in version 0.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We depend on several large libraries that take a while to load. Previously, importing
Tablewould already import almost all of them, leading to horrendous startup times:➡️ 3.5068337 (seconds to import
Tableon main)Now, we lazily import our own modules in the
__init__.pyfiles, and we lazily import external libraries. The latter part is quite ugly, since each function must now contain their external imports at the start. There is no better solution, however, and the improvements are huge:➡️ 0.1683219 (seconds to import
Tablein this branch)We still have to pay the cost for an import once we first import a module, but at least this no longer has to happen fully upfront.