Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove unneeded copy operations in table transformers #496

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Nov 16, 2023

Summary of Changes

#494 enabled Pandas's copy-on-write feature. This PR removes the explicit deep copies that were created in table transformers.

@lars-reimann lars-reimann requested a review from a team as a code owner November 16, 2023 22:36
Copy link
Contributor

github-actions bot commented Nov 16, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 9 0 0 0.85s
✅ PYTHON mypy 9 0 1.8s
✅ PYTHON ruff 9 0 0 0.08s
✅ REPOSITORY git_diff yes no 0.11s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a19389) 100.00% compared to head (5516852) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #496   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2702      2699    -3     
=========================================
- Hits          2702      2699    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit 6443beb into main Nov 16, 2023
8 checks passed
@lars-reimann lars-reimann deleted the cleanup branch November 16, 2023 22:44
lars-reimann pushed a commit that referenced this pull request Nov 22, 2023
## [0.16.0](v0.15.0...v0.16.0) (2023-11-22)

### Features

* drop Python 3.10 and add Python 3.12 ([#478](#478)) ([5bf0e75](5bf0e75))
* enable copy-on-write for pandas dataframes ([#494](#494)) ([9a19389](9a19389)), closes [#428](#428)

### Bug Fixes

* **deps-dev:** Bump urllib3 from 1.26.17 to 1.26.18 ([#480](#480)) ([a592d2c](a592d2c)), closes [#3159](https://github.com/Safe-DS/Library/issues/3159)

### Performance Improvements

* remove unneeded copy operations in table transformers ([#496](#496)) ([6443beb](6443beb)), closes [#494](#494)
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants