-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Image Processing tutorial #419
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 2594 2594
=========================================
Hits 2594 2594
|
…3-tutorial-for-image-processing Hotfix needed for the documentation tests to run through.
Edit: Alright, looks like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few grammatical errors:
Change: All operations on a
Image return a new Image to
All operations on an
Image return a new Image.
Fixed. |
Edit2: Assigned myself to this PR in hope that GitHub finally understands I'm not a reviewer here... Edit3: @jxnior01 You have resolved one conversation, but your other comment still shows as "changes requested". |
When generating docs with @lars-reimann Any ideas? Edit: Solved. |
Did the site fully compile already when you opened it in the browser (see command line)? For me the compilation takes 42 seconds but the site is responsive afterwards. |
Looks like I didn't. Or maybe I accidentally changed something while I was loading the page, causing it to recompile. Works fine when I wait until compilation is over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we already have some performance issues with the docs (#447), I'm wondering if adding a bunch of images will make things worse. @lars-reimann Shall I merge now anyway, or do you prefer to first solve the performance issue? |
That page loads quickly enough for me, so let's merge it if it's done. |
…vent large tables to fill the whole site (#446) Closes #447. ### Summary of Changes docs: Added maximum height to output execution cells in mkdocs to prevent large tables to fill the whole site docs: Removed a warning in the data processing tutorial docs: Added table of contents to data processing tutorial docs: Shorten output in "Data Processing" tutorial to speed up loading the page Used the html note like we discussed in [#419](#419 (comment)) --------- Co-authored-by: megalinter-bot <[email protected]> Co-authored-by: Lars Reimann <[email protected]>
🎉 This PR is included in version 0.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes #373
Summary of Changes
There is a notebook-based documentation page that describes the different image processing methods, including an example for each.