Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Image Processing tutorial #419

Merged
merged 19 commits into from
Jul 12, 2023
Merged

Conversation

robmeth
Copy link
Contributor

@robmeth robmeth commented Jul 5, 2023

Closes #373

Summary of Changes

There is a notebook-based documentation page that describes the different image processing methods, including an example for each.

@robmeth robmeth requested a review from a team as a code owner July 5, 2023 14:24
@robmeth robmeth linked an issue Jul 5, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 1 0 0 0.55s
✅ PYTHON mypy 1 0 1.44s
✅ PYTHON ruff 1 0 0 0.13s
✅ REPOSITORY git_diff yes no 0.12s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #419 (58afeb2) into main (9954986) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #419   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2594      2594           
=========================================
  Hits          2594      2594           
Impacted Files Coverage Δ
src/safeds/data/image/containers/_image.py 100.00% <100.00%> (ø)

…3-tutorial-for-image-processing

Hotfix needed for the documentation tests to run through.
@zzril
Copy link
Contributor

zzril commented Jul 6, 2023

When generating the documentation from this branch with poetry run mkdocs serve, I cannot find the tutorials on the (localhost) webpage.
When I click on Tutorials on the top navigation bar, it still only lists Data processing, Data visualization and Machine Learning.

Looks like we need to add a reference to the new tutorial somewhere. Where?

Edit: Alright, looks like the mkdocs.yml is the place to go.

@zzril zzril changed the title feat: Image Processing tutorial docs: Image Processing tutorial Jul 6, 2023
Copy link
Contributor

@jxnior01 jxnior01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few grammatical errors:
Change: All operations on a Image return a new Image to All operations on an Image return a new Image.

@zzril
Copy link
Contributor

zzril commented Jul 6, 2023

Looks good. Just a few grammatical errors: Change: All operations on a Image return a new Image to All operations on an Image return a new Image.

Fixed.

@zzril
Copy link
Contributor

zzril commented Jul 8, 2023

Note to myself: Need to add adjust_color_balance to the tutorial.
Edit: Done.

Edit2: Assigned myself to this PR in hope that GitHub finally understands I'm not a reviewer here...

Edit3: @jxnior01 You have resolved one conversation, but your other comment still shows as "changes requested".

@zzril
Copy link
Contributor

zzril commented Jul 8, 2023

When generating docs with poetry run mkdocs serve and testing in a browser, the Tutorials page takes ages to load now. (Even before selecting the Image Processing tab.)

@lars-reimann Any ideas?

Edit: Solved.

@zzril zzril requested a review from jxnior01 July 8, 2023 12:39
@zzril zzril dismissed jxnior01’s stale review July 9, 2023 10:06

The requested changes have been adopted.

@zzril zzril requested a review from lars-reimann July 9, 2023 13:40
@lars-reimann
Copy link
Member

lars-reimann commented Jul 9, 2023

When generating docs with poetry run mkdocs serve and testing in a browser, the Tutorials page takes ages to load now. (Even before selecting the Image Processing tab.)

@lars-reimann Any ideas?

Did the site fully compile already when you opened it in the browser (see command line)? For me the compilation takes 42 seconds but the site is responsive afterwards.

@zzril
Copy link
Contributor

zzril commented Jul 9, 2023

When generating docs with poetry run mkdocs serve and testing in a browser, the Tutorials page takes ages to load now. (Even before selecting the Image Processing tab.)
@lars-reimann Any ideas?

Did the site fully compile already when you open it in the browser (see command line)? For me the compilation takes 42 seconds but the site is responsive afterwards.

Looks like I didn't. Or maybe I accidentally changed something while I was loading the page, causing it to recompile.

Works fine when I wait until compilation is over.

Copy link
Contributor

@Marsmaennchen221 Marsmaennchen221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzril
Copy link
Contributor

zzril commented Jul 12, 2023

As we already have some performance issues with the docs (#447), I'm wondering if adding a bunch of images will make things worse.

@lars-reimann Shall I merge now anyway, or do you prefer to first solve the performance issue?

@lars-reimann
Copy link
Member

lars-reimann commented Jul 12, 2023

That page loads quickly enough for me, so let's merge it if it's done.

@lars-reimann lars-reimann merged commit 65a3f48 into main Jul 12, 2023
@lars-reimann lars-reimann deleted the 373-tutorial-for-image-processing branch July 12, 2023 13:39
lars-reimann added a commit that referenced this pull request Jul 12, 2023
…vent large tables to fill the whole site (#446)

Closes #447.

### Summary of Changes

docs: Added maximum height to output execution cells in mkdocs to
prevent large tables to fill the whole site
docs: Removed a warning in the data processing tutorial
docs: Added table of contents to data processing tutorial
docs: Shorten output in "Data Processing" tutorial to speed up loading
the page

Used the html note like we discussed in
[#419](#419 (comment))

---------

Co-authored-by: megalinter-bot <[email protected]>
Co-authored-by: Lars Reimann <[email protected]>
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial for image processing
5 participants