feat: detect the true columntypes when initializing column #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alizing-column-or-table
…alizing-column-or-table
…s-when-initializing-column-or-table' into 322-detected-the-true-columntypes-when-initializing-column-or-table # Conflicts: # src/safeds/data/tabular/typing/_column_type.py # tests/safeds/data/tabular/typing/test_column_type.py
…d still get correct schema by Columns with numbers and missing values
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
daniaHu
changed the title
Co-authored-by: sibre28 <[email protected]>
lars-reimann
deleted the
322-detected-the-true-columntypes-when-initializing-column-or-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Anything Column Type for Columns with mixed values.
Nothing Column Type for Columns with only null values.
Created the method _data_type in column_type class to detect the ColumnType.
Still 3 test failing in: group_by(maybe connected with #129); remove_rows_with_missing_values and transform_column.
The errors are mainly initiated because the values of Table are changing and ColumnType is not being updated. Checking all methods where values are updated and the ColumnType changes could be a solution.