Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suggest similar columns if column gets accessed that doesnt exist #385

Merged
merged 89 commits into from
Jul 13, 2023
Merged

feat: suggest similar columns if column gets accessed that doesnt exist #385

Show file tree
Hide file tree
Changes from 80 commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
be301e2
basic levenshtein method `get_similar_columns` and test
robmeth Jun 23, 2023
13fea9d
test
robmeth Jun 23, 2023
f4324ea
test
robmeth Jun 23, 2023
924ea46
gives list of similar columns
robmeth Jun 23, 2023
859cdc3
add get_similar_columns to other methods, when unknownColumnNameError…
robmeth Jun 23, 2023
f1f9587
updated warning message to also tell the name of the column, that's n…
robmeth Jun 23, 2023
d6fb58e
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jun 23, 2023
e46cecf
adjusted indentation of docstring and changed mode to imperative to a…
jxnior01 Jun 23, 2023
624490e
imported levenshtein differently
jxnior01 Jun 23, 2023
7fdf2a1
changed levenshtein method to `jaro_winkler`
robmeth Jun 23, 2023
df8ab48
added type annotation
robmeth Jun 23, 2023
b282536
installed levenshtein in poetry
jxnior01 Jun 23, 2023
093df64
adjusted docstring to make linter smile
jxnior01 Jun 23, 2023
098b355
style: apply automated linter fixes
megalinter-bot Jun 23, 2023
9aa1ffe
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jun 23, 2023
b705f6e
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jun 23, 2023
fa1bc47
is the linter overloaded?
jxnior01 Jun 23, 2023
e8aa133
Merge remote-tracking branch 'origin/203-suggest-similar-columns-if-c…
jxnior01 Jun 23, 2023
f33851e
Merge branch '203-suggest-similar-columns-if-column-gets-accessed-tha…
robmeth Jun 23, 2023
84d67e1
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jun 23, 2023
9dc5844
made method private, returns list of column names, removed warning, a…
jxnior01 Jun 30, 2023
ad8a433
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
jxnior01 Jun 30, 2023
0954e6a
levenshtein already present in pyproject.toml
jxnior01 Jun 30, 2023
e7a03c4
Merge remote-tracking branch 'origin/203-suggest-similar-columns-if-c…
jxnior01 Jun 30, 2023
a303b16
Merge branch '203-suggest-similar-columns-if-column-gets-accessed-tha…
robmeth Jun 30, 2023
87a1f3c
update usecases of `get_similar_columns` and update UnknownColumnsNam…
robmeth Jun 30, 2023
be5bace
fix UnknownColumnNameError
robmeth Jun 30, 2023
de93962
fix UnknownColumnNameError
robmeth Jun 30, 2023
370a947
fix UnknownColumnNameError
robmeth Jun 30, 2023
c8e4479
fix UnknownColumnNameError
robmeth Jun 30, 2023
300c774
fix UnknownColumnNameError?
robmeth Jun 30, 2023
d85e241
fix UnknownColumnNameError?
robmeth Jun 30, 2023
3969452
fix UnknownColumnNameError?
robmeth Jun 30, 2023
1a21a8a
fix UnknownColumnNameError?
robmeth Jun 30, 2023
ca187ef
fix UnknownColumnNameError?
robmeth Jun 30, 2023
af42744
fix UnknownColumnNameError!
robmeth Jun 30, 2023
ccbc7e6
make linter happy
robmeth Jun 30, 2023
be40d02
make linter happy
robmeth Jun 30, 2023
45266a9
make linter happy
robmeth Jun 30, 2023
0ec7298
make linter happy
robmeth Jun 30, 2023
5e51431
make linter happy
robmeth Jun 30, 2023
ec7a2b2
style: apply automated linter fixes
megalinter-bot Jun 30, 2023
23f1ebd
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jun 30, 2023
96a11aa
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jun 30, 2023
26d19fb
Merge branch '203-suggest-similar-columns-if-column-gets-accessed-tha…
robmeth Jul 7, 2023
24df909
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jul 7, 2023
aae28da
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jul 7, 2023
23d6ee6
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jul 7, 2023
c42a178
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jul 7, 2023
89aa44a
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jul 7, 2023
98f7d6b
Merge branch '203-suggest-similar-columns-if-column-gets-accessed-tha…
robmeth Jul 7, 2023
16778d9
requested changes
robmeth Jul 7, 2023
e57c7df
fix: Corrected the exception for `UnknownColumnNameError` to work wit…
Marsmaennchen221 Jul 7, 2023
4fb7383
linter
robmeth Jul 7, 2023
065da3b
linter
robmeth Jul 7, 2023
a191d61
linter
robmeth Jul 7, 2023
d726aea
Merge branch '203-suggest-similar-columns-if-column-gets-accessed-tha…
robmeth Jul 7, 2023
f34e266
fix: Corrected the exception for UnknownColumnNameError to work with …
robmeth Jul 7, 2023
2b1558a
linter
robmeth Jul 7, 2023
c91b0ae
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jul 7, 2023
f3374cb
style: apply automated linter fixes
megalinter-bot Jul 7, 2023
8e12921
style: apply automated linter fixes
megalinter-bot Jul 7, 2023
8d3dd2c
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jul 12, 2023
2afa433
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
robmeth Jul 12, 2023
b794cad
added test with completely different column name
robmeth Jul 12, 2023
1049dcc
Merge branch '203-suggest-similar-columns-if-column-gets-accessed-tha…
robmeth Jul 12, 2023
885859f
added the dynamically increase of the threshold for when it's more th…
robmeth Jul 12, 2023
e7f83ee
style: apply automated linter fixes
megalinter-bot Jul 12, 2023
01a9ec2
Update src/safeds/data/tabular/containers/_table.py
jxnior01 Jul 13, 2023
1c72f7d
Update src/safeds/data/tabular/containers/_table.py
jxnior01 Jul 13, 2023
60ccac2
Update src/safeds/data/tabular/containers/_table.py
jxnior01 Jul 13, 2023
ebc1261
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
jxnior01 Jul 13, 2023
ac8ccb0
more test cases, modified error message
jxnior01 Jul 13, 2023
6419940
Update dependencies
zzril Jul 13, 2023
29f714f
accepted merge from main, but run wasn't successful, trying poetry ad…
jxnior01 Jul 13, 2023
ea5ea5d
Merge remote-tracking branch 'origin/203-suggest-similar-columns-if-c…
jxnior01 Jul 13, 2023
d8dc7f3
Update tests/safeds/data/tabular/containers/_table/test_get_similar_c…
jxnior01 Jul 13, 2023
3eb4f31
style: apply automated linter fixes
megalinter-bot Jul 13, 2023
fef4550
Update src/safeds/exceptions/_data.py
jxnior01 Jul 13, 2023
7e73ba7
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
Marsmaennchen221 Jul 13, 2023
9bd0df0
passed UnknownColumnNameError an empty list in constructor
jxnior01 Jul 13, 2023
649b70f
last commit :)
jxnior01 Jul 13, 2023
5061634
style: apply automated linter fixes
megalinter-bot Jul 13, 2023
53f598b
style: apply automated linter fixes
megalinter-bot Jul 13, 2023
73c9508
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
jxnior01 Jul 13, 2023
dd252a0
Revert poetry.lock
zzril Jul 13, 2023
d24b0b5
Add testcases
zzril Jul 13, 2023
ab37198
style: apply automated linter fixes
megalinter-bot Jul 13, 2023
fdd47ca
Merge branch 'main' into 203-suggest-similar-columns-if-column-gets-a…
Marsmaennchen221 Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading