Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten some names #772

Closed
lars-reimann opened this issue May 15, 2024 · 1 comment · Fixed by #787
Closed

Shorten some names #772

lars-reimann opened this issue May 15, 2024 · 1 comment · Fixed by #787
Assignees
Labels
released Included in a release

Comments

@lars-reimann
Copy link
Member

lars-reimann commented May 15, 2024

  • Replace maximum with max (already done in some places)
  • Replace minimum with min (already done in some places)
  • Document "allowed" abbreviations in guidelines
  • Replace number_of with _count (already done for e.g. missing_value_count)

For example, minimum_number_of_samples_in_leaves could become min_sample_count_in_leaves. Saves some line width at basically no loss of readability.

@github-project-automation github-project-automation bot moved this to Backlog in Library May 15, 2024
@lars-reimann lars-reimann self-assigned this May 17, 2024
@lars-reimann lars-reimann linked a pull request May 17, 2024 that will close this issue
lars-reimann added a commit that referenced this issue May 17, 2024
Closes #772

### Summary of Changes

* Attributes or parameters that describe a count/number of something now
have the suffix `_count` instead of the prefix `number_of`.
* Abbreviate `maximum` to `max` and `minimum` to `min`.
* Update project guidelines.

---------

Co-authored-by: megalinter-bot <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library May 17, 2024
lars-reimann pushed a commit that referenced this issue May 29, 2024
## [0.26.0](v0.25.0...v0.26.0) (2024-05-29)

### Features

* `Table.count_row_if` ([#788](#788)) ([4137131](4137131)), closes [#786](#786)
* added method to load pretrained models from huggingface ([#790](#790)) ([dd8394b](dd8394b))
* infer input size of forward and LSTM layers ([#808](#808)) ([098a07f](098a07f))
* outline around dots of scatterplot ([#785](#785)) ([ee8acf7](ee8acf7))
* remove output conversions ([#792](#792)) ([46f2f5d](46f2f5d)), closes [#732](#732)
* shorten some excessively long names ([#787](#787)) ([1c3ea59](1c3ea59)), closes [#772](#772)
* specify column names in constructor of table transformers ([#795](#795)) ([69a780c](69a780c))
* store window size and forecast horizon in dataset ([#794](#794)) ([f07bc5a](f07bc5a))
* string operations on cells ([#791](#791)) ([4a17f76](4a17f76))

### Bug Fixes

* handling of boolean columns in column statistics ([#778](#778)) ([f61cceb](f61cceb))
* sort x values of line plot ([#782](#782)) ([74d8649](74d8649))
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant