Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace other values than NaN with imputer #707

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 3, 2024

Closes #643

Summary of Changes

  • Add an optional argument to Imputer to configure the value_to_replace. This can be an int, float, or string.

Copy link
Contributor

github-actions bot commented May 3, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 3 0 0 0.88s
✅ PYTHON mypy 3 0 2.05s
✅ PYTHON ruff 3 0 0 0.23s
✅ REPOSITORY git_diff yes no 0.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (36e4a7a) to head (ace83be).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #707   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           67        66    -1     
  Lines         4785      4811   +26     
=========================================
+ Hits          4785      4811   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann force-pushed the 643-imputer-should-also-work-if-missing-values-are-not-represented-by-nullnan branch from e2e1cb0 to 00ee018 Compare May 3, 2024 19:05
@lars-reimann lars-reimann force-pushed the 643-imputer-should-also-work-if-missing-values-are-not-represented-by-nullnan branch from 00ee018 to ace83be Compare May 3, 2024 19:08
@lars-reimann lars-reimann marked this pull request as ready for review May 3, 2024 19:13
@lars-reimann lars-reimann requested a review from a team as a code owner May 3, 2024 19:13
@lars-reimann lars-reimann merged commit 4a059e0 into main May 3, 2024
8 checks passed
@lars-reimann lars-reimann deleted the 643-imputer-should-also-work-if-missing-values-are-not-represented-by-nullnan branch May 3, 2024 19:13
lars-reimann pushed a commit that referenced this pull request May 4, 2024
## [0.23.0](v0.22.1...v0.23.0) (2024-05-04)

### Features

* add `Column.to_table` ([#705](#705)) ([36e4a7a](36e4a7a)), closes [#695](#695)
* added Column.summarize_statistics() ([#715](#715)) ([71730a9](71730a9)), closes [#701](#701)
* replace other values than NaN with imputer ([#707](#707)) ([4a059e0](4a059e0)), closes [#643](#643)

### Bug Fixes

* use UTF-8 encoding when opening files ([#704](#704)) ([f8c27bc](f8c27bc))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imputer should also work if missing values are not represented by null/NaN
2 participants