Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imputer should also work if missing values are not represented by null/NaN #643

Closed
lars-reimann opened this issue Apr 23, 2024 · 1 comment · Fixed by #707
Closed

Imputer should also work if missing values are not represented by null/NaN #643

lars-reimann opened this issue Apr 23, 2024 · 1 comment · Fixed by #707
Assignees
@lars-reimann
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

Is your feature request related to a problem?

We've had an example where missing values where represented by the value 0. This meant that the imputer could not be used.

Desired solution

  • Option 1: Specify how missing values are encoded when creating a table.
  • Option 2: Specify the value to replace in the imputer.

We might also combine both solutions.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Apr 23, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Library Apr 23, 2024
@lars-reimann lars-reimann self-assigned this May 3, 2024
@lars-reimann lars-reimann moved this from Backlog to In Progress in Library May 3, 2024
@lars-reimann lars-reimann mentioned this issue May 3, 2024
Merged
@lars-reimann lars-reimann linked a pull request May 3, 2024 that will close this issue
feat: replace other values than NaN with imputer #707
Merged
lars-reimann added a commit that referenced this issue May 3, 2024
@lars-reimann @megalinter-bot
feat: replace other values than NaN with imputer (#707)
4a059e0 
Closes #643

### Summary of Changes

* Add an optional argument to `Imputer` to configure the
`value_to_replace`. This can be an int, float, or string.

---------

Co-authored-by: megalinter-bot <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to ✔️ Done in Library May 3, 2024
lars-reimann pushed a commit that referenced this issue May 4, 2024
@semantic-release-bot
chore(release): 0.23.0 [skip ci]
6a8bbdc 
## [0.23.0](v0.22.1...v0.23.0) (2024-05-04)

### Features

* add `Column.to_table` ([#705](#705)) ([36e4a7a](36e4a7a)), closes [#695](#695)
* added Column.summarize_statistics() ([#715](#715)) ([71730a9](71730a9)), closes [#701](#701)
* replace other values than NaN with imputer ([#707](#707)) ([4a059e0](4a059e0)), closes [#643](#643)

### Bug Fixes

* use UTF-8 encoding when opening files ([#704](#704)) ([f8c27bc](f8c27bc))
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
enhancement 💡 New feature or request released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: replace other values than NaN with imputer Safe-DS/Library
1 participant
@lars-reimann