Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call predict of classical ML models with TabularDataset #694

Closed
lars-reimann opened this issue May 2, 2024 · 1 comment · Fixed by #752
Closed

Call predict of classical ML models with TabularDataset #694

lars-reimann opened this issue May 2, 2024 · 1 comment · Fixed by #752
Assignees
@lars-reimann
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

Is your feature request related to a problem?

Right now, a TabularDataset must first be converted to a Table before being passed to predict. This is unnecessary.

Desired solution

  • Allow passing a TabularDataset to predict.
  • Internally, call toTable, if given a TabularDataset.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label May 2, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Library May 2, 2024
@lars-reimann lars-reimann self-assigned this May 10, 2024
@lars-reimann lars-reimann mentioned this issue May 11, 2024
Merged
lars-reimann added a commit that referenced this issue May 11, 2024
@lars-reimann
feat: major API redesign (WIP) (#752)
8e781f9 
Closes #694
Closes #699
Closes #714
Closes #748 

### Summary of Changes

* Replace old implementation of tabular containers
* New, more efficient implementation of metrics
* Standalone package for metrics
* New regression metrics
* Abstract base class for classifiers & regressors
* Introspection methods to get information about features and target of
supervised models
* Rename `LogisticRegressionClassifier` to `LogisticClassifier` (shorter
+ does not show up when searching for regression)
* Rename `LinearRegressionRegressor` to `LinearRegressor` (shorter)
* Rename `SupportVectorMachineClassifier` to `SupportVectorClassifier`
(a little less precise, but still unambiguous and shorter)
* Rename `SupportVectorMachineRegressor` to `SupportVectorRegressor`
(ditto)
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library May 11, 2024
lars-reimann pushed a commit that referenced this issue May 15, 2024
@semantic-release-bot
chore(release): 0.25.0 [skip ci]
69d7d73 
## [0.25.0](v0.24.0...v0.25.0) (2024-05-15)

### Features

* major API redesign (WIP) ([#752](#752)) ([8e781f9](8e781f9)), closes [#694](#694) [#699](#699) [#714](#714) [#748](#748)
* move NN converters and layers to separate packages ([#759](#759)) ([c6a4073](c6a4073))
* remove operations without replacement from tabular containers ([#747](#747)) ([0e5a54b](0e5a54b))
* specify partial order in label encoder ([#763](#763)) ([6fbe537](6fbe537)), closes [#639](#639)

### Bug Fixes

* Conversion of tabular dataset to tensors ([#757](#757)) ([9e40b65](9e40b65))
* fixed devices with new polars implementation ([#756](#756)) ([e72339e](e72339e))

### Performance Improvements

* implement one hot encoder and imputer using polars ([#768](#768)) ([e993c17](e993c17))
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
enhancement 💡 New feature or request released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: major API redesign (WIP) Safe-DS/Library
1 participant
@lars-reimann