feat: add gaussian noise to image #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added gaussian noise
Closed
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
…-add-gaussian-noise
…-add-gaussian-noise
…-add-gaussian-noise
Marsmaennchen221
changed the title
…-add-gaussian-noise # Conflicts: # tests/safeds/data/image/containers/test_image.py
…-add-gaussian-noise
lars-reimann
reviewed
Jul 7, 2023
lars-reimann
reviewed
Jul 7, 2023
lars-reimann
changed the title
lars-reimann
changed the title
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 2665 2676 +11
=========================================
+ Hits 2665 2676 +11
|
lars-reimann
force-pushed
the
381-add-gaussian-noise
branch
from
f1265c2 to
dbba115
Compare
Marsmaennchen221
previously approved these changes
Jul 12, 2023
|
Need to add the new method to the image tutorial also. Or do we generally create new issues for that? @lars-reimann |
No, that should be added as part of this PR now that #419 is merged. |
lars-reimann
force-pushed
the
381-add-gaussian-noise
branch
from
ff576c5 to
3b79e29
Compare
|
It's now added to the "Image Processing" tutorial. |
lars-reimann
force-pushed
the
381-add-gaussian-noise
branch
from
3b79e29 to
e80d993
Compare
|
Tests fail locally for me ( |
|
Run |
Ofc, thanks. |
zzril
previously approved these changes
Jul 12, 2023
There was a problem hiding this comment.
LGTM.
(Small remark about the tests: I think it would generally make sense to always include the edge cases (like giving a standard_deviation of 0) in the test cases.
But we're not doing that consistently anyway, so I'll still accept. Might be sthg for a new issue.)
|
Thanks, I've added that edge case too. |
lars-reimann
pushed a commit
that referenced
this pull request
Jul 13, 2023
## [0.15.0](v0.14.0...v0.15.0) (2023-07-13) ### Features * Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275) * add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381) * add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127) * add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402) * added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380) * added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349) * discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143) * Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150) * Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58) * new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262) * rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439) * suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203) ### Bug Fixes * added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362) * don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5)) * Warnings raised by underlying seaborn and numpy libraries ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #381
Summary of Changes
Images can now be modified with "gaussian noise".