Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in type hint (pd.Dataframe) in _table.py #180

Closed
zzril opened this issue Apr 14, 2023 · 1 comment · Fixed by #184
Closed

Typo in type hint (pd.Dataframe) in _table.py #180

zzril opened this issue Apr 14, 2023 · 1 comment · Fixed by #184
Assignees
Labels
bug 🪲 Something isn't working good first issue Good for newcomers released Included in a release

Comments

@zzril
Copy link
Contributor

zzril commented Apr 14, 2023

Describe the bug

In data/tabular/containers/_table.py:

IDE is complaining about pd.Dataframe, type hint; should be pd.DataFrame.

To Reproduce

Open data/tabular/containers/_table.py in PyCharm and check warnings.

Expected behavior

There should be no typo and the IDE should not complain. :d

Screenshots (optional)

No response

Additional Context (optional)

No response

@zzril zzril added the bug 🪲 Something isn't working label Apr 14, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Library Apr 14, 2023
@lars-reimann lars-reimann added the good first issue Good for newcomers label Apr 14, 2023
@lars-reimann lars-reimann self-assigned this Apr 14, 2023
@lars-reimann lars-reimann moved this from Backlog to In Progress in Library Apr 14, 2023
@lars-reimann lars-reimann linked a pull request Apr 14, 2023 that will close this issue
lars-reimann added a commit that referenced this issue Apr 14, 2023
Closes #180.

### Summary of Changes

* Change `pd.Dataframe` to `pd.DataFrame`
@github-project-automation github-project-automation bot moved this from In Progress to ✔️ Done in Library Apr 14, 2023
lars-reimann pushed a commit that referenced this issue Apr 21, 2023
## [0.11.0](v0.10.0...v0.11.0) (2023-04-21)

### Features

* `OneHotEncoder.inverse_transform` now maintains the column order from the original table ([#195](#195)) ([3ec0041](3ec0041)), closes [#109](#109) [#109](#109)
* add `plot_` prefix back to plotting methods ([#212](#212)) ([e50c3b0](e50c3b0)), closes [#211](#211)
* adjust `Column`, `Schema` and `Table` to changes in `Row` ([#216](#216)) ([ca3eebb](ca3eebb))
* back `Row` by a `polars.DataFrame` ([#214](#214)) ([62ca34d](62ca34d)), closes [#196](#196) [#149](#149)
* clean up `Row` class ([#215](#215)) ([b12fc68](b12fc68))
* convert between `Row` and `dict` ([#206](#206)) ([e98b653](e98b653)), closes [#204](#204)
* convert between a `dict` and a `Table` ([#198](#198)) ([2a5089e](2a5089e)), closes [#197](#197)
* create column types for `polars` data types ([#208](#208)) ([e18b362](e18b362)), closes [#196](#196)
* dataframe interchange protocol ([#200](#200)) ([bea976a](bea976a)), closes [#199](#199)
* move existing ML solutions into `safeds.ml.classical` package ([#213](#213)) ([655f07f](655f07f)), closes [#210](#210)

### Bug Fixes

* `table.keep_only_columns` now maps column names to correct data ([#194](#194)) ([459ab75](459ab75)), closes [#115](#115)
* typo in type hint ([#184](#184)) ([e79727d](e79727d)), closes [#180](#180)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working good first issue Good for newcomers released Included in a release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants