-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf: Faster plot_histograms and more reliable plots (#659)
## Fixed problem that histogram get plottet a lot faster ### Summary of Changes - rewrote the entire funtion - reduce numerical bins to a given parameter for more performance (default 10) - Bins are now also sorted - sometimes specific columns had strange plots, these are also now fixed - swaped the images for the test with new ones --------- Co-authored-by: Lars Reimann <[email protected]>
- Loading branch information
1 parent
6013eb2
commit b5f0a12
Showing
5 changed files
with
54 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+524 Bytes
(100%)
...__snapshots__/test_plot_histograms/test_should_match_snapshot[four columns].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+114 Bytes
(100%)
...e/__snapshots__/test_plot_histograms/test_should_match_snapshot[one column].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+19.1 KB
...grams/test_should_match_snapshot[two columns with compressed visualization].png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters