Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

More thorough tests #16

Closed
lars-reimann opened this issue Mar 14, 2023 · 1 comment · Fixed by #22
Closed

More thorough tests #16

lars-reimann opened this issue Mar 14, 2023 · 1 comment · Fixed by #22
Assignees
@lars-reimann
Labels
released Included in a release testing 🧪 Additional automated tests

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Mar 14, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe

Right now we only check that the data can be read by the stdlib but not whether it works well as an example.

Desired solution

More thorough tests of the created Table (schema, number of rows).
@lars-reimann lars-reimann added the testing 🧪 Additional automated tests label Mar 14, 2023
@lars-reimann lars-reimann self-assigned this Mar 14, 2023
@github-project-automation github-project-automation bot moved this to Backlog in Library Mar 14, 2023
@lars-reimann lars-reimann moved this from Backlog to Todo in Library Mar 14, 2023
@lars-reimann lars-reimann mentioned this issue Mar 15, 2023
Merged
@lars-reimann lars-reimann linked a pull request Mar 15, 2023 that will close this issue
test: test Titanic example more thoroughly #22
Merged
lars-reimann added a commit that referenced this issue Mar 15, 2023
@lars-reimann
test: test Titanic example more thoroughly (#22)
54c568f 
Closes #16.

### Summary of Changes

Now we also check
* number of rows
* schema
* which columns have missing values.

---------

Co-authored-by: lars-reimann <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to ✔️ Done in Library Mar 15, 2023
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lars-reimann lars-reimann

Labels
released Included in a release testing 🧪 Additional automated tests
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: test Titanic example more thoroughly Safe-DS/Datasets
1 participant
@lars-reimann