fix: also handle literal types when computing upper bound #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1103 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 106 106
Lines 20799 20801 +2
Branches 4090 4091 +1
=========================================
+ Hits 20799 20801 +2 ☔ View full report in Codecov by Sentry. |
lars-reimann
pushed a commit
that referenced
this pull request
May 2, 2024
## [0.14.0](v0.13.0...v0.14.0) (2024-05-02) ### Features * `this` expression ([#1111](#1111)) ([c7bd0fa](c7bd0fa)), closes [#1107](#1107) [#1110](#1110) * allow literal types as upper bounds of type parameters ([#1102](#1102)) ([c14159b](c14159b)), closes [#1081](#1081) * Check truthiness of value ([#1131](#1131)) ([0b059a1](0b059a1)) * check usages of `@PythonName` and `@PythonCall` on overriding methods ([#1100](#1100)) ([3021166](3021166)) * partial code generation for multiple targets ([#1114](#1114)) ([5461a1b](5461a1b)), closes [#1079](#1079) * Stubs for `safe-ds` version 0.22.1 ([#1130](#1130)) ([6f7100d](6f7100d)) * various methods to work with strings ([#1112](#1112)) ([b6d4f16](b6d4f16)), closes [#1108](#1108) * visibility modifiers for any module member ([#1104](#1104)) ([3d43d38](3d43d38)), closes [#1083](#1083) ### Bug Fixes * also handle literal types when computing upper bound ([#1103](#1103)) ([3f1ab6f](3f1ab6f)), closes [#1081](#1081)
|
🎉 This PR is included in version 0.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1081
Summary of Changes
Also update the type computer to handle literal types as upper bounds of type parameters.