Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide classes that are only for typing in auto-completion and rank them down in the search #1026

Closed
lars-reimann opened this issue Apr 12, 2024 · 1 comment · Fixed by #1056
Closed

Hide classes that are only for typing in auto-completion and rank them down in the search #1026

lars-reimann opened this issue Apr 12, 2024 · 1 comment · Fixed by #1056
Assignees
@lars-reimann
Labels
documentation 📖 Improvements or additions to documentation enhancement 💡 New feature or request released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension
Milestone
v0.12.0

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Apr 12, 2024 •
edited
Loading

Is your feature request related to a problem?

Classes that

  1. don't have a constructor
  2. don't have static members

are only used for typing. However, they

  1. still get suggested by auto-completion,
  2. still show up prominently in the search.

Desired solution

  1. Hide them in auto-completion
  2. Rank them down for searching
  3. Display an info that they are only for typing.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added documentation 📖 Improvements or additions to documentation enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension labels Apr 12, 2024
@lars-reimann lars-reimann added this to the v0.12.0 milestone Apr 12, 2024
@lars-reimann lars-reimann self-assigned this Apr 12, 2024
@lars-reimann lars-reimann added this to DSL Apr 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DSL Apr 12, 2024
@lars-reimann lars-reimann moved this from Backlog to Todo in DSL Apr 12, 2024
@lars-reimann lars-reimann moved this from Todo to In Progress in DSL Apr 15, 2024
@lars-reimann lars-reimann mentioned this issue Apr 15, 2024
Merged
@lars-reimann lars-reimann linked a pull request Apr 15, 2024 that will close this issue
feat: hide classes that are only for typing from auto-completion #1056
Merged
lars-reimann added a commit that referenced this issue Apr 15, 2024
@lars-reimann
feat: hide classes that are only for typing from auto-completion (#1056)
50851d7 
Closes #1026

### Summary of Changes

Classes that are only for typing (no constructor, no static members) do
not show up in auto-completion of references anymore. They also get
ranked down in the search of the documentation site.
@github-project-automation github-project-automation bot moved this from In Progress to ✔️ Done in DSL Apr 15, 2024
lars-reimann pushed a commit that referenced this issue Apr 18, 2024
@semantic-release-bot
chore(release): 0.12.0 [skip ci]
7180e52 
## [0.12.0](v0.11.0...v0.12.0) (2024-04-18)

### Features

* better error if `+` is used for string concatenation ([#1044](#1044)) ([8be49c5](8be49c5))
* collapse class/literal types in inlay hints ([#1053](#1053)) ([7db2820](7db2820)), closes [#1048](#1048)
* **deps:** require latest runner (`v0.11.0`) ([#1058](#1058)) ([7ae1f6b](7ae1f6b))
* don't stop validation at syntax errors ([#1049](#1049)) ([db0c5d7](db0c5d7))
* error if name of static member equals name of inherited member ([#1054](#1054)) ([b8e17af](b8e17af))
* hide classes that are only for typing from auto-completion ([#1056](#1056)) ([50851d7](50851d7)), closes [#1026](#1026)
* ignore parameter names for default values and yields ([#1059](#1059)) ([dde4de0](dde4de0))
* ignore parameter names when type checking arguments ([#1052](#1052)) ([a1e6717](a1e6717)), closes [#1046](#1046)
* installer for the runner ([#1038](#1038)) ([2bde594](2bde594))
* map literals are no longer experimental ([#1039](#1039)) ([1d9af4b](1d9af4b))
* separate VS Code languages for pipeline/stub/tests ([#1043](#1043)) ([8147480](8147480))
* support for examples in documentation comments ([#1045](#1045)) ([3da6d6f](3da6d6f)), closes [#1027](#1027)
* updater for the runner ([#1042](#1042)) ([610d45b](610d45b))

### Bug Fixes

* don't sync `safe-ds.runner.command` setting ([bb57481](bb57481))
* save all files before opening the EDA tool ([d6d0c22](d6d0c22))
* start runner if configuration did not change after installation ([#1040](#1040)) ([b4f015a](b4f015a))
* substitute type parameters for lambda parameters ([#1050](#1050)) ([46145dd](46145dd)), closes [#1047](#1047)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
documentation 📖 Improvements or additions to documentation enhancement 💡 New feature or request released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension
Projects
DSL
Archived in project
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

feat: hide classes that are only for typing from auto-completion Safe-DS/DSL
1 participant
@lars-reimann