Skip to content

Commit

Permalink
fix: runner not shutting down when extension was closed (#1094)
Browse files Browse the repository at this point in the history
### Summary of Changes

Graceful shutdown of the runner now works again.
  • Loading branch information
lars-reimann authored Apr 24, 2024
1 parent 31b8a28 commit 77a0c1f
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import {
UpdateRunnerNotification,
} from '../communication/rpc.js';

const LOWEST_SUPPORTED_RUNNER_VERSION = '0.11.0';
const LOWEST_UNSUPPORTED_RUNNER_VERSION = '0.12.0';
const LOWEST_SUPPORTED_RUNNER_VERSION = '0.12.0';
const LOWEST_UNSUPPORTED_RUNNER_VERSION = '0.13.0';
const npmVersionRange = `>=${LOWEST_SUPPORTED_RUNNER_VERSION} <${LOWEST_UNSUPPORTED_RUNNER_VERSION}`;
export const pipVersionRange = `>=${LOWEST_SUPPORTED_RUNNER_VERSION},<${LOWEST_UNSUPPORTED_RUNNER_VERSION}`;

Expand Down Expand Up @@ -435,7 +435,7 @@ export class SafeDsPythonServer {
* @param message Message to be sent to the python server. This message should be serializable to JSON.
*/
public sendMessageToPythonServer(message: PythonServerMessage): void {
if (!isStarted(this.state)) {
if (!this.state.serverConnection) {
return;
}

Expand Down

0 comments on commit 77a0c1f

Please sign in to comment.