fix(gui): is:done filter crashes app (#943)

* fix(gui): `is:done` filter crashes app * style: apply automatic fixes of linters Co-authored-by: lars-reimann <[email protected]>
Safe-DS · Jul 8, 2022 · 92c93dc · 92c93dc
1 parent f5bb873
commit 92c93dc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/api-editor/gui/src/features/filter/model/DoneFilter.ts b/api-editor/gui/src/features/filter/model/DoneFilter.ts
@@ -46,13 +46,17 @@ export class DoneFilter extends AbstractPythonFilter {
 
     private getAnnotationsForTarget(target: string, annotationStore: AnnotationStore): Annotation[] {
         return Object.entries(annotationStore).flatMap(([key, value]) => {
+            if (typeof value !== 'object') {
+                return [];
+            }
+
             if (!(target in value)) {
                 return [];
             }
 
-            if (key === 'calledAfters' || key === 'groups') {
+            if (key === 'calledAfterAnnotations' || key === 'groupAnnotations') {
                 return Object.values(value[target]);
-            } else if (key === 'completes') {
+            } else if (key === 'completeAnnotations') {
                 return [];
             } else {
                 return [value[target]];

diff --git a/api-editor/gui/src/features/menuBar/MenuBar.tsx b/api-editor/gui/src/features/menuBar/MenuBar.tsx
@@ -64,7 +64,7 @@ import { useLocation, useNavigate } from 'react-router-dom';
 import { SelectionBreadcrumbs } from './SelectionBreadcrumbs';
 import { HelpMenu } from './HelpMenu';
 import { AnnotationStore } from '../annotations/versioning/AnnotationStoreV2';
-import { supportedAnnotationStoreSchemaVersions } from '../annotations/versioning/expectedVersions';
+import { EXPECTED_ANNOTATION_STORE_SCHEMA_VERSION } from '../annotations/versioning/expectedVersions';
 
 interface MenuBarProps {
     displayInferErrors: (errors: string[]) => void;
@@ -99,8 +99,7 @@ export const MenuBar: React.FC<MenuBarProps> = function ({ displayInferErrors })
                 JSON.stringify(
                     {
                         ...annotationStore,
-                        schemaVersion:
-                            supportedAnnotationStoreSchemaVersions[supportedAnnotationStoreSchemaVersions.length - 1],
+                        schemaVersion: EXPECTED_ANNOTATION_STORE_SCHEMA_VERSION,
                     },
                     null,
                     4,