Added 'Quit' option under 'File' #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yishn
requested changes
Sep 21, 2020
|
Thank you! I will try to implement the necessary changes. |
yishn
requested changes
Sep 22, 2020
src/menu.js
Outdated
Comment on lines
875
to
881
| let preferenceItem = fileMenu.submenu.splice( | ||
| fileMenu.submenu.length - 2, | ||
| fileMenu.submenu.length - 4, | ||
| 2 | ||
| )[1] | ||
|
|
||
| fileMenu.submenu.splice(fileMenu.length - 2, 2)[1] | ||
|
|
There was a problem hiding this comment.
Instead you can write
.splice(
fileMenu.submenu.length - 4,
4
)[1]to remove the four last entries, so there's no need for two separate mutations.
There was a problem hiding this comment.
I have done so. I am sorry for requiring so much feedback, as I am new to JavaScript and I thought that it would be clearer if all that the code defining preferenceItemremoved was the 'Preferences' option.
|
Thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a 'Quit' option under the 'File' menu. (#741)