Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a default keyboard shortcut to display the score Estimation #345

Closed
wctgit opened this issue Feb 26, 2018 · 8 comments
Closed

Offer a default keyboard shortcut to display the score Estimation #345

wctgit opened this issue Feb 26, 2018 · 8 comments

Comments

@wctgit
Copy link

wctgit commented Feb 26, 2018

Currently, you must click on the hamburger and Estimate to show an estimation. It would be much more convenient to have a default keyboard shortcut assigned to this action, and especially to allow multiple re-estimations without having to click the x to close the score estimator display (since the score estimation may change each time, sometimes by a lot, and clicking x, then hamburger, then Estimate is way too many steps just to get a quick re-estimate).

@yishn
Copy link
Member

yishn commented Feb 26, 2018

Can you suggest a fitting keyboard shortcut? What about scoring the game? I feel like if 'Estimate' has a keyboard shortcut, then 'Score' should have one, too.

@wctgit
Copy link
Author

wctgit commented Feb 26, 2018

Well, I'm not sure what kind of keyboard shortcut style you prefer. You've got Ctrl-I for Game Info, and Ctrl-Shift-M for Manage Games, which are two I'm currently using frequently. A straightforward extension of that would be Ctrl-E, Ctrl-S, but Ctrl-S is usually Save, so maybe Ctrl-Shift-E, Ctrl-Shift-S? Alternatively, you could use some of the F keys, like F5, F6, or whatever. Finally, you could offer a default shortcut and offer users to be able to edit the shortcuts, but this would take more work.

Another possibility I can think of, based on my own mnemonic would be Ctrl-= for Estimate, and Ctrl-Shift-= for Score.

@yishn
Copy link
Member

yishn commented Feb 26, 2018

Ctrl+E is 'Toggle Edit Mode', Ctrl+Shift+S is 'Save As...', so... not really an option. F5 and F6 are currently reserved for GTP engines, and keyboard shortcuts with special characters like = are bad for international keyboards.

I've given some thought about this and I didn't find any good keyboard shortcuts for Estimate and Score, so that's why I was asking.

@wctgit
Copy link
Author

wctgit commented Feb 26, 2018

Do keyboard shortcuts necessarily require a modifier key? Why not just 'E' and 'S'? How about Ctrl-NumPad+ for Estimate and Ctrl-Enter and/or Ctrl-NumPadEnter for Score? Numpad keys no good either? Honestly, anything is better than nothing, IMHO. Use Ctrl-7 or Ctrl-P for all I care. :-) I'll learn whatever the key is.

@yishn
Copy link
Member

yishn commented Feb 26, 2018

Ctrl+Plus and Ctrl+Minus are controlling the zoom. Differentiating between Enter and NumPadEnter is not a very good idea, also some laptops don't even have a numpad. Press Ctrl+P to pass. Ctrl+{1-9} are reserved for edit tools. Ctrl+0 resets the zoom.

@yishn
Copy link
Member

yishn commented Feb 26, 2018

Keyboard shortcuts don't necessarily require a modifier key. But it's good style to have one. Because you won't be able to activate a keyboard shortcut when, for example, a textbox is focused, if you don't have a modifier key.

I think we can still use K, U, and D with Ctrl...

@wctgit
Copy link
Author

wctgit commented Feb 26, 2018

You can also use Ctrl-Alt, Alt-Shift, and Ctrl-Alt-Shift. I used to work for a company that made a GUI for programmers, and we ended up using all sorts of combinations (as well as user-customizable).

@weaver299
Copy link

What about Ctrl-Shift-E for Estimate, and Ctrl-Shift-R for scoRe?

Apologies if those have already been addressed and I didn't catch it... I saw Ctrl-Shift-E was mentioned but it didn't look like that specific one had been ruled out. I tried these while viewing a game in edit mode and not edit mode (tested on Mac only) and they didn't seem to do anything..

Command-Shift-E/R on Mac would preferable but Control-Shift-E/R would be fine too.

I would love this feature too, because I'm often stepping through my games and trying to observe the change in score estimate... I was actually thinking it would be cool if we could still navigate the game tree without turning the estimate off at all.. but just the hotkeys would be a big help.

Thanks for your excellent work! Best SGF UI I've ever used...

@yishn yishn closed this as completed in e2dce4c Feb 28, 2020
yishn added a commit that referenced this issue Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants