remove some TODOs

Saadnajmi · Aug 21, 2024 · 64b395e · 64b395e
1 parent c18c037
commit 64b395e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.mm b/packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.mm
@@ -149,7 +149,7 @@ - (RCTPlatformView *)viewWithModuleName:(NSString *)moduleName // [macOS]
         initWithSurface:surface
         sizeMeasureMode:RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact];
 
-#if !TARGET_OS_OSX // [macOS] TODO SAAD
+#if !TARGET_OS_OSX // [macOS]
     surfaceHostingProxyRootView.backgroundColor = [UIColor systemBackgroundColor];
 #endif // [macOS]
     if (self->_configuration.customizeRootView != nil) {
@@ -185,7 +185,7 @@ - (RCTPlatformView *)createRootViewWithBridge:(RCTBridge *)bridge
   BOOL enableFabric = self->_configuration.fabricEnabled;
   RCTPlatformView *rootView = RCTAppSetupDefaultRootView(bridge, moduleName, initProps, enableFabric); // [macOS]
 
-#if !TARGET_OS_OSX // [macOS] TODO SAAD
+#if !TARGET_OS_OSX // [macOS]
   rootView.backgroundColor = [UIColor systemBackgroundColor];
 #endif // [macOS]
 

diff --git a/...r/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTTextLayoutManager.mm b/...r/textlayoutmanager/platform/ios/react/renderer/textlayoutmanager/RCTTextLayoutManager.mm
@@ -107,7 +107,7 @@ - (void)drawAttributedString:(AttributedString)attributedString
                                   withinSelectedGlyphRange:range
                                            inTextContainer:textContainer
                                                 usingBlock:^(CGRect enclosingRect, __unused BOOL *anotherStop) {
-#if !TARGET_OS_OSX // [macOS] TODO SAAD - Import RCTUIKit?
+#if !TARGET_OS_OSX // [macOS] We dont' have access to RCTUIKit, so let's copy the implementation here
                                                   UIBezierPath *path = [UIBezierPath
                                                       bezierPathWithRoundedRect:CGRectInset(enclosingRect, -2, -2)
                                                                    cornerRadius:2];
@@ -118,7 +118,7 @@ - (void)drawAttributedString:(AttributedString)attributedString
                                                                         yRadius:2];
 #endif // macOS[
                                                   if (highlightPath) {
-#if !TARGET_OS_OSX // [macOS] TODO SAAD - Import RCTUIKit?
+#if !TARGET_OS_OSX // [macOS]
                                                     [highlightPath appendPath:path];
 #else // [macOS
                                                     [highlightPath appendBezierPath:path];