Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[+] Card Implementation: Rush Clovis & Clear the Field Implementation… #422

Merged
merged 8 commits into from
Jan 14, 2025
Merged

[+] Card Implementation: Rush Clovis & Clear the Field Implementation… #422

merged 8 commits into from
Jan 14, 2025

Conversation

HugoHMZ
Copy link
Collaborator

@HugoHMZ HugoHMZ commented Jan 8, 2025

image
image

@HugoHMZ HugoHMZ requested a review from AMMayberry1 as a code owner January 8, 2025 18:54
@HugoHMZ
Copy link
Collaborator Author

HugoHMZ commented Jan 8, 2025 •
edited
Loading

@AMMayberry1 hey, quick question. About this comment

Test with two different versions of a unique unit to confirm that cards will match even if the subtitles are different
Try with a leader whose name matches to confirm that it doesn't try to return it to hand and break the game

i tried to look up for some card names I could use to test it but i cannot find any (more especially since they need to cost under 4 energy). Do you have any names to give me so i can try more comfortably ?

HugoHMZ added 2 commits January 9, 2025 23:59
@HugoHMZ HugoHMZ marked this pull request as draft January 9, 2025 17:16
[+] Clear the Field: remove duplicates of cards inside the targets ar…
aa6480e 
…ray, update to match title instead of internal name and match all cards apart from leader units
@HugoHMZ HugoHMZ marked this pull request as ready for review January 10, 2025 04:50
@HugoHMZ HugoHMZ requested a review from AMMayberry1 January 13, 2025 13:25
@HugoHMZ HugoHMZ requested a review from AMMayberry1 January 14, 2025 07:10
@AMMayberry1 AMMayberry1 merged commit df2ed75 into main Jan 14, 2025
2 checks passed
@AMMayberry1 AMMayberry1 deleted the Balkhrog/Implementation-RushClovis&ClearTheField branch January 14, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMMayberry1 AMMayberry1 AMMayberry1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HugoHMZ @AMMayberry1