Bossk leader #405
Merged
Bossk leader #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the bounty resolution process to create an explicit "onBountyCollected" event, and made it possible to store the properties of the bounty keyword in the event. Added the CollectBountySystem which the Bossk ability uses to re-trigger the bounty ability.
Added a big test suite to cover the various types of bounties and ensure that all can double-resolve correctly. Added some specific detailed tests for the Bounty Hunter's Quarry case, including an open TODO on one case while we wait for clarification on some rules.