Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide opposing players cards in the gamestate #396

Merged
merged 5 commits into from
Jan 5, 2025

Conversation

farisT
Copy link
Collaborator

@farisT farisT commented Dec 27, 2024

  • Removed the hideWhenFaceup element (remnant from jigoku engine)
  • Return facedown cards with no details based off active player and zone (e.g. only show opposing cards when they are in play)

@farisT farisT requested a review from AMMayberry1 as a code owner December 27, 2024 14:22
@danbastin
Copy link
Collaborator

Condition looks right to me. This should be good to g.

@farisT farisT force-pushed the fix/hide-opposing-players-cards branch from a1f17dc to cd891c8 Compare January 4, 2025 09:42
@AMMayberry1
Copy link
Collaborator

Just a note - please don't force push if at all possible, it erases the review history and makes it harder to identify the new changes.

@AMMayberry1 AMMayberry1 merged commit 7ad1d0e into main Jan 5, 2025
2 checks passed
@AMMayberry1 AMMayberry1 deleted the fix/hide-opposing-players-cards branch January 5, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants