-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Che bato/end game screen #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- first pass at end game screen
- Second pass for endgamescreen
- Final pass
- Added homepage preferences
- Added Logout button
- Design fixes
# Conflicts: # src/app/_contexts/Game.context.tsx # src/app/lobby/page.tsx
danbastin
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of quick bugs:
- When returning to the lobby for a new game players should not be ready
- With the end game windows up after one player leaves the other play cannot close the window
- Intermediate work.
- Cleanup for PR and added button changes based on the state.
- Cleanup for PR and added button changes based on the state.
danbastin
reviewed
Jan 18, 2025
src/app/_components/_sharedcomponents/Preferences/_subComponents/VerticalTabs.tsx
Outdated
Show resolved
Hide resolved
- Cleanup for PR
- Cleanup for PR.
…ato/EndGameScreen
- changed background.
danbastin
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End game screen & Homepage preferences
GameBoard/page.tsx
Preferences/page.tsx
Controlhub.tsx
OpponentCardTray.tsx
SetUp.tsx (lobby)
PreferencesComponent.tsx
BlockListTab.tsx
Preferences.types.ts
CardSleevesTab.tsx
CurrentGameTab.tsx
EndGameTab.tsx
GameOptionsTab.tsx & KeyboardShortcutsTab.tsx
BlockedUser.tsx
EndGameOptionsCustom.tsx
EndGameOptionsQuickMatch
PreferenceButton.tsx
VerticalTabs.tsx
Game.context.tsx
User.context.tsx
Lobby/page.tsx
quickGame/page.tsx
new changes