Make SvgCanvas class accessible from bundle #964
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the bundle version of svgedit (as a package
npm i svgedit
), and I wanna useconvertUnit
utility which was defined in the module packages/svgcanvas/core/units.js and attached to SvgCanvas class so I thought it should be used as below:but the following error arised:
getRoundDigits
(or evengetBaseUnit
if I just callSvgCanvas.convertUnit(38)
) is a method of SvgCanvas instance created by EditorStartup during initialization and consequently injected to the moduleunits.js
.The problem is that the instance of
SvgCanvas
is actually in the bundle, not in@svgedit/svgcanvas
.I fixed this issue in a simple way, just re-exporting
SvgCanvas
from Editor.js as show in this pull request but there could be other ways.