Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial stroke width #959

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

delmohf
Copy link
Contributor

@delmohf delmohf commented Apr 16, 2024

Trying to set the initial stroke width now work as expected

svgEditor.setConfig({
    initStroke: {
        width: 5
    }
});

@delmohf
Copy link
Contributor Author

delmohf commented Apr 17, 2024

Hi guys! Is there any plan to merge this PR into master?

@jfhenon
Copy link
Collaborator

jfhenon commented Apr 17, 2024

Hi guys! Is there any plan to merge this PR into master?

Yes but tests are not passing anymore... This is normal as your fix impacts the tests. If you fix the tests, I will merge immediately. If not, I need a few days to look into this. It should not be difficult. thanks for the contribution anyway.

@jfhenon jfhenon merged commit 04ab3dd into SVG-Edit:master Apr 18, 2024
5 checks passed
@delmohf delmohf deleted the fix-initial-stroke-width branch April 24, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants