Fix for import svg image leading to unattached dragtool #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…doesnt know the svg to select
ibrierley
changed the title
| @@ -5083,7 +5083,8 @@ this.importSvgString = function(xmlString) { | |||
| return false; | |||
There was a problem hiding this comment.
Please change this to return null
Changed docs and return value to match if unsuccessful
codedread
added a commit
that referenced
this pull request
Feb 1, 2016
Fix for import svg image leading to unattached dragtool
|
Sorry for the delay on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you import an svg image, it loads it, but then the dragtool appears on its own, not connected to the newly imported element.
When the element is imported, it isn't known 'what' this element is, so the change is to make the method return the element, so we can then use it, to 'select it, once the load is complete.
I cannot see any other methods reliant on the return value of this (which previously returned true rather than the element).