Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V7 preview #480

Merged
merged 138 commits into from
Mar 5, 2021
Merged

V7 preview #480

merged 138 commits into from
Mar 5, 2021

Conversation

jfhenon
Copy link
Collaborator

@jfhenon jfhenon commented Mar 5, 2021

PR description

Checklist

Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.

  • - Added Cypress UI tests
  • - Ran npm test, ensuring linting passes and that Cypress UI tests keep
    coverage to at least the same percent (reflected in the coverage badge
    that should be updated after the tests run)
  • - Added any user documentation. Though not required, this can be a big
    help both for future users and for the PR reviewer.

jfhenon and others added 30 commits January 3, 2021 23:46
@jfhenon
Merge pull request #30 from SVG-Edit/V7-preview
6cdb338 
V7 preview
@AgriyaDev5
#issue-fix The new menu will ask if you want to erase the current con…
12ad6e4 
…tent but it will ignore the answer
@AgriyaDev5
#issue-fix dialog needs to be closer than the original
dc92748
@AgriyaDev5
#issue-fix main menu alignment changes
62d63b3
@AgriyaDev5
#issue_fix double click and opensvg issue fixed
b173b6c
@jfhenon
Merge pull request #32 from OptimistikSAS/issue-fix
4e9b4b6 
Issue fix
@AgriyaDev5
#issue-fix process_cancel change to seConfirm
a092406
@AgriyaDev5
#issue-fix review how the top toolbar display when many buttons are d…
feaedc5 
…isplayed
@AgriyaDev5
#issue-fix unwanted css reoved
9e36768
@AgriyaDev5
#issue-fix BOTTOM TOOLS Make sure all features of the bottom toolbar …
f351c37 
…are working
@jfhenon
Merge pull request #33 from OptimistikSAS/issue-fix
1986cfa 
Issue fix
@AgriyaDev5
#issue-fix IMPORT IMAGE menu open issue fixed
72022f1
@AgriyaDev5
#issue-fix alert dialog overwrite style
9297fd8
@AgriyaDev5
#issue-fix lint issue fixed
8bdc198
@AgriyaDev5
Merge branch 'V7-preview' of https://github.com/OptimistikSAS/svgedit …
208b1d5 
…into issue-fix
@jfhenon
Merge pull request #34 from OptimistikSAS/issue-fix
25b5a2d 
Issue fix
@jfhenon
npm update + associated fixes
ad877e7
@AgriyaDev5
#36 look of opacity button should like the zoom button (without the d…
ebf9f1e 
…ropdown button)
@jfhenon
Merge pull request #54 from /issues/36
11c4f73 
#36 look of opacity button should like the zoom button (without the d…
@AgriyaDev5
#37 Clicking anywhere on the bottom bar (for example below the opacit…
94f6366 
…y button is displaying the “color popup”.)
@AgriyaDev5
#38 The opacity button does not update with the current element
08032c4
@jfhenon
Merge pull request #56 from /issues/38
f4b3d12 
#38 The opacity button does not update with the current element
@jfhenon
Merge pull request #55 from /issues/37
4cc0212 
#37 Clicking anywhere on the bottom bar open color popup
@AgriyaDev5
#42 When you import an image, it works well but the dialog should dis…
720b35d 
…appear automatically
@AgriyaDev5
Fixes #53: 4th option for the background display fixed
6262a63
@AgriyaDev5
Fixes #53: 4th option for the background fixed
27f9052
@jfhenon
Merge pull request #58 from /issues/42
5c11a9c 
#42 When you import an image,  dialog should disappear automatically
@jfhenon
Merge pull request #57 from OptimistikSAS/issue/53
b0408d6 
Fixes #53: 4th option for the background display fixed
@AgriyaDev5
#49 the x button does not work
975bea6
@jfhenon
Merge pull request #59 from /issues/49
8d97f7e 
#49 the x button does not work
AgriyaDev5 and others added 28 commits February 22, 2021 19:44
@AgriyaDev5
#43 With a small window, the look of the top toolbar is broken
7dbd6ce
@jfhenon
Merge pull request #75 from OptimistikSAS/issue/43
4e12aa3 
#43 With a small window, the look of the top toolbar is broken
@jfhenon
Merge pull request #74 from /issues/45
e6e382e 
#45 These buttons don't work and dropdown is broken
@jfhenon
Merge pull request #73 from /issues/46
766c2d0 
#46 Move this jQuery component to a web component
@jfhenon
Update jQuery.jPicker.js
24dbbeb
@AgriyaDev5
#76 draggable modification changes
6f6d056
@AgriyaDev5
#76 jquery-ui-1.8.17.custom.min.js removed from editor
ece0700
@AgriyaDev5
#76 jquery ui file removed
f3e10c2
@jfhenon
Merge pull request #77 from /issues/76
9bac20e 
#76 jquery ui removed
@jfhenon
npm update
82ed16c
@AgriyaDev5
#77 console issue fixed
e9a4326
@AgriyaDev5
#77 <SVG> button issue fixed
fd5eca2
@AgriyaDev5
#77 shortkey issue fixed
70d07bd
@AgriyaDev5
#77 jquery hotkeys plugin changes
7906460
@jfhenon
Merge pull request #78 from OptimistikSAS/issue/77
041c99a 
#77 short key issue, console error and svg button issue fixed
@AgriyaDev5
#77 hotkey plugin related changes
9aeec1f
@AgriyaDev5
#78 hotkey related code comment.
fc39dcf
@AgriyaDev5
#78 js-hotkeys/jquery.hotkeys.min.js file removed from svgedit.js
bac4d9b
@AgriyaDev5
#51 Rewrite the color palette without elix
b80a49f
@AgriyaDev5
#81 unwanted files removed
e101c7f
@AgriyaDev5
#81 folder name renamed
8a3272d
@AgriyaDev5
#81 folder rename changes
3bb7e4e
@jfhenon
Merge pull request #79 from OptimistikSAS/issue/78
0758867
@jfhenon
Merge pull request #80 from /issues/51
bf7fbf9
@AgriyaDev5
#81 jquery-ui folder renamed
85f2e36
@AgriyaDev5
#81 jquery modify changes
5384fb6
@AgriyaDev5
#81 globals $ removed
1febc85
@jfhenon
Merge pull request #82 from /issues/81
10b717b 
#81 Jquery remove
@jfhenon jfhenon merged commit 1af0cd0 into SVG-Edit:V7-preview Mar 5, 2021
@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2021

This pull request introduces 5 alerts when merging 10b717b into 974a472 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Property access on null or undefined
  • 1 for Prototype-polluting function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfhenon @AgriyaDev5 @mathieucura