Intersection list #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
codedread
commented
Dec 1, 2015
codedread
commented
- use getIntersectionList() when available (Opera, Chrome, Safari).
- remove all suspendRedraws() - that API is removed in SVG 2
|
This change looks great, just one minor comment nit. Is this covered by a unittest? If so--does the test pass in both firefox and chrome? |
|
This PR fixes Issue #36 |
|
"Is this covered by a unittest?" The sad answer is no - we never really wrote unit tests back in the early days of SVG-edit. I only started when I began trying to disentangle all the code and split things out into modules. I'd prefer to hold off on writing unit tests for svgcanvas since it's such a tangled mess still... |
progers
added a commit
that referenced
this pull request
Dec 2, 2015
Use getIntersectionList when available, remove suspendRedraws calls
|
And we're in! |
jfhenon
added a commit
that referenced
this pull request
Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.