-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo Redo Key Binding #59
Comments
Can you send a pull request? |
Done. By the way, it seems like this is happening with the latest demo version (link on front page of the product's github page) so it doesn't seem to be an older version or anything to blame. I'm using Firefox 43.0.4. P.s. this will NOT effect the compiled javascript file... so that would have to be done too. |
#59 Remove double-bind of keypresses Z and Y
Looks like this can be safely closed with the PR having been merged... Feel free to comment if otherwise... |
Issue: The keypresses "Z" and "Y" trigger undo/redo respectively BUT Z is also tied to Zoom, so while pressing Z you get both actions (undo & zoom) triggered. So, when you go to hit the zoom key, your last action is undone!
I fixed this issue by changing this:
To
Found in svg-editor.js around line 4020 (when not using compiled assets).
Undo / Redo can still be triggered by pressing [modKey] + Z or [modKey] + Y respectively so you're not losing anything with this change.
The text was updated successfully, but these errors were encountered: