fix side effects

SVG-Edit · Dec 9, 2023 · 7478dc4 · 7478dc4
1 parent e6e1a37
commit 7478dc4
Show file tree

Hide file tree

Showing 14 changed files with 531 additions and 430 deletions.
diff --git a/coverage/coverage-summary.json b/coverage/coverage-summary.json
diff --git a/cypress/__svgSnapshots__/scenario6-check tool_polygon_align_to_page.svg b/cypress/__svgSnapshots__/scenario6-check tool_polygon_align_to_page.svg
diff --git a/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_sides.svg b/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_sides.svg
diff --git a/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_stoke_fill_color.svg b/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_stoke_fill_color.svg
diff --git a/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_stroke_width.svg b/cypress/__svgSnapshots__/scenario6-check tool_polygon_change_stroke_width.svg
diff --git a/cypress/__svgSnapshots__/scenario7-check tool_star_align_to_page.svg b/cypress/__svgSnapshots__/scenario7-check tool_star_align_to_page.svg
diff --git a/cypress/__svgSnapshots__/scenario7-check tool_star_change_sides.svg b/cypress/__svgSnapshots__/scenario7-check tool_star_change_sides.svg
diff --git a/cypress/__svgSnapshots__/scenario7-check tool_star_change_stoke_fill_color.svg b/cypress/__svgSnapshots__/scenario7-check tool_star_change_stoke_fill_color.svg
diff --git a/cypress/__svgSnapshots__/scenario7-check tool_star_change_stroke_width.svg b/cypress/__svgSnapshots__/scenario7-check tool_star_change_stroke_width.svg
diff --git a/cypress/e2e/unit/utilities-bbox.cy.js b/cypress/e2e/unit/utilities-bbox.cy.js
@@ -5,6 +5,7 @@ import * as utilities from '../../../packages/svgcanvas/core/utilities.js'
 import * as math from '../../../packages/svgcanvas/core/math.js'
 import * as path from '../../../packages/svgcanvas/core/path.js'
 import setAssertionMethods from '../../support/assert-close.js'
+import * as units from '../../../packages/svgcanvas/core/units.js'
 
 // eslint-disable-next-line
 chai.use(setAssertionMethods)
@@ -94,6 +95,7 @@ describe('utilities bbox', function () {
     }
 
     path.init(mockSvgCanvas)
+    units.init({ getRoundDigits: () => 2 }) // mock getRoundDigits
     mockaddSVGElementsFromJsonCallCount = 0
   })
 

diff --git a/cypress/e2e/unit/utilities-performance.cy.js b/cypress/e2e/unit/utilities-performance.cy.js
@@ -4,9 +4,12 @@ import 'pathseg'
 import { NS } from '../../../packages/svgcanvas/core/namespaces.js'
 import * as utilities from '../../../packages/svgcanvas/core/utilities.js'
 import * as math from '../../../packages/svgcanvas/core/math.js'
+import * as units from '../../../packages/svgcanvas/core/units.js'
+
 
 describe('utilities performance', function () {
   let currentLayer; let groupWithMatrixTransform; let textWithMatrixTransform
+  units.init({ getRoundDigits: () => 2 }) // mock getRoundDigits
   beforeEach(() => {
     document.body.textContent = ''
     const style = document.createElement('style')

diff --git a/packages/svgcanvas/core/undo.js b/packages/svgcanvas/core/undo.js
@@ -169,7 +169,6 @@ export const changeSelectedAttributeNoUndoMethod = (attr, newValue, elems) => {
       const bbox = getStrokedBBoxDefaultVisible([elem])
       const diffX = attr === 'x' ? parseFloat(newValue) - bbox.x : 0
       const diffY = attr === 'y' ? parseFloat(newValue) - bbox.y : 0
-      console.log('diffX, diffY', diffX, diffY)
       svgCanvas.moveSelectedElements(diffX * zoom, diffY * zoom, true)
       continue
     }
@@ -190,7 +189,7 @@ export const changeSelectedAttributeNoUndoMethod = (attr, newValue, elems) => {
       } else if (attr === '#href') {
         setHref(elem, newValue)
       } else if (newValue) {
-        elem.setAttribute(attr, parseFloat(newValue))
+        elem.setAttribute(attr, isNaN(parseFloat(newValue)) ? newValue : parseFloat(newValue))
       } else if (typeof newValue === 'number') {
         elem.setAttribute(attr, newValue)
       } else {