Fix kubectl server-side dry-run flag (backport to v4.5) #1463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
The flag of server-side dry-run is different at k8s client < 1.18.0 and k8s client >= 1.18.0.
What does this PR do?
Check the kubectl client version and return the corresponding server-side dry-run flag.
If k8s client version < v1.18.0, the server-side dry-run flag is
--server-dry-run
.If k8s client version >= v1.18.0, the server-side dry-run flag is
--dry-run=server
.Anything else a reviewer needs to know?
N/A
Info for QA
This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug.
If this is a new feature, a good description in "What does this PR do" may be enough.
Related info
N/A
Status BEFORE applying the patch
Status AFTER applying the patch
AND
Docs
N/A
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises: