-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] addons: Remove cilium-init image (bsc#1172270) #1384
Merged
vadorovsky
merged 1 commit into
SUSE:maintenance-caasp-v4.2
from
vadorovsky:4.2-remove-cilium-init
Oct 2, 2020
Merged
[4.2] addons: Remove cilium-init image (bsc#1172270) #1384
vadorovsky
merged 1 commit into
SUSE:maintenance-caasp-v4.2
from
vadorovsky:4.2-remove-cilium-init
Oct 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmnelemane
previously approved these changes
Oct 2, 2020
jenting
previously approved these changes
Oct 2, 2020
manuelbuil
previously approved these changes
Oct 2, 2020
We don't ship a separate cilium-init image anymore. The cilium-init script is included in the main cilium container image. Fixes: SUSE/avant-garde#1923 Signed-off-by: Michal Rostecki <[email protected]>
vadorovsky
dismissed stale reviews from manuelbuil, jenting, and mmnelemane
via
October 2, 2020 15:58
c7c1a31
vadorovsky
force-pushed
the
4.2-remove-cilium-init
branch
from
October 2, 2020 15:58
280e04b
to
c7c1a31
Compare
vadorovsky
changed the title
addons: Remove cilium-init image (bsc#1172270)
[4.2] addons: Remove cilium-init image (bsc#1172270)
Oct 2, 2020
rktidwell
approved these changes
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
soumynathan
reviewed
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
mmnelemane
approved these changes
Oct 2, 2020
vadorovsky
added a commit
that referenced
this pull request
Oct 9, 2020
Revert "Merge pull request #1384 from mrostecki/4.2-remove-cilium-init"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't ship a separate cilium-init image anymore. The cilium-init
script is included in the main cilium container image.
Fixes: SUSE/avant-garde#1923
Signed-off-by: Michal Rostecki [email protected]