Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkinsfile.integration: use python3.11 for jcs #704

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

kshtsk
Copy link
Contributor

@kshtsk kshtsk commented Jun 26, 2023

It appears in the newer openstackclient code the new feature available starting from Python 3.7:

  from __future__ import annotations

For more info see:
https://peps.python.org/pep-0563/#enabling-the-future-behavior-in-python-3-7

Since the default Python in Leap 15.4 is still 3.6, so maybe just start using the latest available 3.11 for jcs.

@kshtsk kshtsk force-pushed the wip-handle-pep-0563-future-annotations branch from 970db48 to 65a5cf9 Compare June 26, 2023 13:47
@kshtsk kshtsk requested a review from tserong June 26, 2023 15:24
It appears in the newer openstackclient code the new feature
available starting from Python 3.7:

  from __future__ import annotations

For more info see:
  https://peps.python.org/pep-0563/#enabling-the-future-behavior-in-python-3-7

Since the default Python in Leap 15.4 is still 3.6, so maybe just
start using the latest available 3.11 for jcs.

Fixes: SUSE#703

Signed-off-by: Kyrylo Shatskyy <[email protected]>
@kshtsk
Copy link
Contributor Author

kshtsk commented Jun 26, 2023

@tserong

    master: ++ ceph-salt --version

    master: ceph-salt 16.2.4

    master: ++ salt -G ceph-salt:member state.apply ceph-salt

    master: ERROR: Minions returned with non-zero exit code

    master: master.mini.test:

    master:     Minion did not return. [No response]

    master:     The minions may not have all finished running and any remaining minions will return upon completion. To look up the return data for this job later, run the following command:

    master: 

    master:     salt-run jobs.lookup_jid 20230626142659772098


Something in test. I recommend to merge this PR it does not touch the code where the test failing.

@tserong
Copy link
Member

tserong commented Jun 28, 2023

Something in test. I recommend to merge this PR it does not touch the code where the test failing.

Yeah, that's that irritating intermittent problem I've been trying to hunt down, and is unrelated to this fix.

Thanks!

@tserong tserong merged commit b25cf97 into SUSE:master Jun 28, 2023
@kshtsk kshtsk deleted the wip-handle-pep-0563-future-annotations branch June 28, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants