Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seslib: Ignore Podman 2.2.1 in octopus #634

Merged
merged 1 commit into from
Mar 4, 2022
Merged

seslib: Ignore Podman 2.2.1 in octopus #634

merged 1 commit into from
Mar 4, 2022
+5 −0

Conversation

p-se
Copy link
Member

@p-se p-se commented Mar 3, 2022

Ignore Podman 2.2.1 in octopus as it contains an unfixed bug that, in
conjunction with using --network=host leads to an /etc/hosts entry
being added which confuses Pythons socket.getfqdn() function and leads
to inaccessible links in ceph mgr services.

Fixes: #633

Signed-off-by: Patrick Seidensal [email protected]

@p-se p-se force-pushed the fix-container-fqdn branch from d0ffbec to c805b21 Compare March 3, 2022 13:56
@p-se
Copy link
Member Author

p-se commented Mar 3, 2022

😁

@p-se p-se requested review from smithfarm, kshtsk and tserong March 3, 2022 14:26
@smithfarm
Copy link
Collaborator

LGTM but if I were doing this I would put this code in zypper.j2 (the idea was not to have zypper commands scattered all through the Jinja code, but to concentrate them all in one place).

https://github.com/SUSE/sesdev/blob/master/seslib/templates/zypper.j2

kshtsk
kshtsk approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@kshtsk kshtsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks trivial, I didn't check it but if you sure ok to merge

@p-se
Copy link
Member Author

p-se commented Mar 3, 2022

Looks trivial, I didn't check it but if you sure ok to merge

The continuous-integration/jenkins/pr-head check finally went through because of this :)

@p-se
Copy link
Member Author

p-se commented Mar 3, 2022 •
edited
Loading

LGTM but if I were doing this I would put this code in zypper.j2 (the idea was not to have zypper commands scattered all through the Jinja code, but to concentrate them all in one place).

Thanks, I'll check that script!

@p-se
seslib: Ignore Podman 2.2.1 in octopus
3fe369d 
Ignore Podman 2.2.1 in `octopus` as it contains an unfixed bug that, in
conjunction with using `--network=host`, leads to an `/etc/hosts` entry
being added which confuses Pythons `socket.getfqdn()` function and leads
to inaccessible links in `ceph mgr services`.

Fixes: SUSE#633

Signed-off-by: Patrick Seidensal <[email protected]>
@p-se p-se force-pushed the fix-container-fqdn branch from c805b21 to 3fe369d Compare March 4, 2022 10:01
@p-se p-se added the bug label Mar 4, 2022
@p-se p-se merged commit 48da3fd into SUSE:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshtsk kshtsk kshtsk approved these changes

@smithfarm smithfarm Awaiting requested review from smithfarm

@tserong tserong Awaiting requested review from tserong

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR: SUSE dashboard branding appears to be completely absent!
3 participants
@p-se @smithfarm @kshtsk