Fixes for the next maintenance update #126
Conversation
…e supported in the get-Functions too. This should fix the problem with some special Azure VMs (E20d_v5) on newer SLES SPs (jsc#SAPSOL-110)
system/cpu.go
Outdated
| state, _ := GetSysString(path.Join(cpuDirSys, entry.Name(), "cpuidle", centry.Name(), "disable")) | ||
| // save latency states for 'revert' | ||
| // savedStates = "cpu1:state0:0 cpu1:state1:0" | ||
| savedStates = savedStates + " " + entry.Name() + ":" + centry.Name() + ":" + state |
There was a problem hiding this comment.
The first time that savedStates will be overwrite there will have at first a empty string than a space, is this produce something wrong with the result? If so is possible to remove the first whitespace on the return at line 357 with savedStates[1:]
There was a problem hiding this comment.
the whitespace at the beginning of the string is not a problem as the string will be later used in function SetForceLatency(..) with strings.Fields(savedStates), which will split the string into pieces around consecutive white space characters.
system/cpu.go
Outdated
| } | ||
| for _, entry := range dirCont { | ||
| // cpu0 ... cpuXY | ||
| if isCPU.MatchString(entry.Name()) { |
There was a problem hiding this comment.
Why don't create a variable for entry.Name()? entry.Name() will be called multiple time and this can increase the time computing of the block because entry.Name() have is own time to compute. We are probably talking about insignificant nanoseconds, but you never know :)
There was a problem hiding this comment.
yes, good idea. See new commit
system/cpu.go
Outdated
| supported = true | ||
| for _, centry := range cpudirCont { | ||
| // state0 ... stateXY | ||
| if isState.MatchString(centry.Name()) { |
There was a problem hiding this comment.
done with new commit, thanks
Co-authored-by: GabrielePuliti <[email protected]>
change handling of the performance options (cpu governor, perf bias and force latency)
Check, if the settings are supported, in the get-Functions too.
This should fix the problem with some special Azure VMs (E20d_v5) on newer SLES SPs (jsc#SAPSOL-110)
support inline comments in /etc/sysconfig/saptune
fix formating and typos