-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsc#1174919 #85
bsc#1174919 #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments and approving based on our discussion but we should look at some of the suggested cleanup.
echo "...but received status ${code}; will check again in a minute ..." | ||
sleep 60 | ||
echo "...but received status $code; will check again shortly ..." | ||
sleep 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UAA doesn't come up until about 20+ minutes into the CAP deploy and because of the asynchronous nature of the helm installs (with wait = false
) this script can kick in right after the helm installs have triggered so waiting for only 10s is lot of unnecessary polling but only gaining little less than a minute in triggering the final metrics install.
name = "susecf-metrics" | ||
repository = "https://kubernetes-charts.suse.com" | ||
chart = "metrics" | ||
version = "1.2.1" | ||
namespace = "metrics" | ||
wait = "false" | ||
wait = "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this to be true - there's nothing else dependent on it. The CAP deployment will take its time too and we are telling the end user to check the pod status for readiness.
@@ -127,7 +119,9 @@ resource "helm_release" "scf" { | |||
resource "helm_release" "stratos" { | |||
depends_on = [ | |||
helm_release.scf, | |||
kubernetes_namespace.stratos | |||
kubernetes_namespace.stratos, | |||
null_resource.cluster_issuer_setup, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? In v1, stratos is not using cert-manager.
"AWS_ACCESS_KEY_ID" = var.access_key_id | ||
"AWS_SECRET_ACCESS_KEY" = var.secret_access_key | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this to avoid the token expiry problem? Could using the load_config_file = true
work?
Issues noted; I'll resolve in a subsequent PR. |
bsc#1174919
Deploy in EKS can fail due to operations taking longer than the expiration period of the k8s auth token generated by terraform, and terraform not having a built-in mechanism to renew the token:
hashicorp/terraform#24886
I'm working around this by ensuring kubernetes operations occur up-front, and helm operations use the
kubecontrol
file instead, which request a new token on each use.In addition, due to other outstanding issues, we've elected to upgrade the
helm
andkubernetes
provider versions.