Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

spec/integration: added integration testing #848

Merged
merged 1 commit into from
May 2, 2016

Conversation

mssola
Copy link
Collaborator

@mssola mssola commented Apr 28, 2016

This commit is the foundation for integration testing in the Portus repository.
It uses docker containers to setup everything, and a lot of magic has been
written around RSpec so it integrates with the style of the other tests.

This commit does not handle on purpose the following (which have been submitted
as separate issues):

  • Test multiple versions of Docker.
  • Test crono
  • Test portusctl
  • Cover as much of the registry client as possible
  • Add integration testing into CI

Fixes #745

Signed-off-by: Miquel Sabaté Solà [email protected]

@mssola mssola force-pushed the integration-testing branch from bbd8b85 to 475c2ce Compare April 28, 2016 08:43
desc "Properly test Portus"
task :test do |_, args|
tags = args.extras.map { |a| "--tag #{a}" }
tags << "--tag ~integration" if ENV["TRAVIS"] == "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we cannot run integration tests on travis, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for now. I tried to do it (in multiple different ways) but I had lots of problems. I opened #847 for this same reason.

@flavio
Copy link
Member

flavio commented Apr 29, 2016

It looks good, there are some really minor issues to fix 👏

Two nice things we can figure out in the future:

  • have a summary table showing how the test are doing with docker client version + registry version
  • be able to test everything using portus from RPM packages

@mssola
Copy link
Collaborator Author

mssola commented Apr 29, 2016

have a summary table showing how the test are doing with docker client version + registry version

That's already solved :) Take a look at this line of code inside of the setup_describe method:

  describe "#{name} (distribution: #{version}) (LDAP: #{ldap?})", tags do

When we support multiple docker versions, we can just add it to this string 😉

be able to test everything using portus from RPM packages

Maybe related to #845 ?

@mssola
Copy link
Collaborator Author

mssola commented Apr 29, 2016

I'll be pushing fixes without squashing. I'll squash all my commits whenever it's ready to be merged 😉

@flavio
Copy link
Member

flavio commented Apr 29, 2016

Good, ping me when you need another review to be done.

@mssola mssola force-pushed the integration-testing branch from 1b15d45 to ba89ba2 Compare April 29, 2016 16:08
This commit is the foundation for integration testing in the Portus repository.
It uses docker containers to setup everything, and a lot of magic has been
written around RSpec so it integrates with the style of the other tests.

This commit does not handle on purpose the following (which have been submitted
as separate issues):

  - Test multiple versions of Docker.
  - Test crono
  - Test portusctl
  - Cover as much of the registry client as possible
  - Add integration testing into CI

Fixes SUSE#745

Signed-off-by: Miquel Sabaté Solà <[email protected]>
@mssola mssola force-pushed the integration-testing branch from ba89ba2 to f93f3f0 Compare April 29, 2016 16:28
@mssola
Copy link
Collaborator Author

mssola commented Apr 29, 2016

@flavio should be fine now 😉

@flavio
Copy link
Member

flavio commented May 2, 2016

LGTM!

@mssola mssola merged commit 5ff0a85 into SUSE:master May 2, 2016
@mssola mssola deleted the integration-testing branch May 2, 2016 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants