-
Notifications
You must be signed in to change notification settings - Fork 473
spec/integration: added integration testing #848
Conversation
bbd8b85
to
475c2ce
Compare
desc "Properly test Portus" | ||
task :test do |_, args| | ||
tags = args.extras.map { |a| "--tag #{a}" } | ||
tags << "--tag ~integration" if ENV["TRAVIS"] == "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we cannot run integration tests on travis, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for now. I tried to do it (in multiple different ways) but I had lots of problems. I opened #847 for this same reason.
It looks good, there are some really minor issues to fix 👏 Two nice things we can figure out in the future:
|
That's already solved :) Take a look at this line of code inside of the describe "#{name} (distribution: #{version}) (LDAP: #{ldap?})", tags do When we support multiple docker versions, we can just add it to this string 😉
Maybe related to #845 ? |
I'll be pushing fixes without squashing. I'll squash all my commits whenever it's ready to be merged 😉 |
Good, ping me when you need another review to be done. |
1b15d45
to
ba89ba2
Compare
This commit is the foundation for integration testing in the Portus repository. It uses docker containers to setup everything, and a lot of magic has been written around RSpec so it integrates with the style of the other tests. This commit does not handle on purpose the following (which have been submitted as separate issues): - Test multiple versions of Docker. - Test crono - Test portusctl - Cover as much of the registry client as possible - Add integration testing into CI Fixes SUSE#745 Signed-off-by: Miquel Sabaté Solà <[email protected]>
ba89ba2
to
f93f3f0
Compare
@flavio should be fine now 😉 |
LGTM! |
This commit is the foundation for integration testing in the Portus repository.
It uses docker containers to setup everything, and a lot of magic has been
written around RSpec so it integrates with the style of the other tests.
This commit does not handle on purpose the following (which have been submitted
as separate issues):
Fixes #745
Signed-off-by: Miquel Sabaté Solà [email protected]