This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Serve all the vendor fonts and font-awesome locally #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
I've updated the PR so it also includes other missing vendor fonts. |
mssola
changed the title
| @@ -1,2 +1,3 @@ | |||
| Rails.application.config.assets.version = "1.0" | |||
| Rails.application.config.assets.precompile += %w( auth/cover.js ) | |||
| Rails.application.config.assets.precompile << /\.(?:woff2)\z/ | |||
There was a problem hiding this comment.
wouldn't it be easier (for understanding) to use globbing? ie Rails.application.config.assets.precompile += %w( auth/cover.js *.woff2 )
This is important if we want Portus to be available in setups that don't have access to an external network. Signed-off-by: Miquel Sabaté Solà <[email protected]>
|
@salzig you're right. I've updated the patch. |
|
I think this can be merged right now. |
mssola
added a commit
that referenced
this pull request
Nov 10, 2015
Serve all the vendor fonts and font-awesome locally
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, all the font-awesome related stuff will be served locally, instead of
bootstrap's CDN. This is important if we want Portus to be available in setups
that don't have access to an external network.
Signed-off-by: Miquel Sabaté Solà [email protected]